Alamofire ( Alamofire )

In 2023 OSes, URL now follows RFC 3986 and automatically encodes URL components with proper escaping. This reduces the cases where strings can't properly be converted to URLs automatically, so new test values had to be found. Using an empty string brings back the old behavior.

Fixed: For apps linked on or after iOS 17 and aligned OS versions, URL parsing has updated from the obsolete RFC 1738/1808 parsing to the same RFC 3986 parsing as URLComponents. This unifies the parsing behaviors of the URL and URLComponents APIs. Now, URL automatically percent- or IDNA-encodes invalid characters to help create a valid URL. To check if a urlString is strictly valid according to the RFC, use the new URL(string: urlString, encodingInvalidCharacters: false) initializer. This init leaves all characters as they are and will return nil if urlString is explicitly invalid. (93368104)

+36 -9

2 commit in Alamofire/Alamofire/tree/2023-test-failures Alamofire/Alamofire/tree/master

0 comment

4 changed files

jshier

pr closed time in 18 hours

push eventAlamofire/Alamofire

Jon Shier

commit sha 98c28e683253e920f5220d4456c5e4a6da7aa941

Update URL Conversion Tests (#3734) ### Goals :soccer: This PR updates some failing tests for the first Xcode 15 beta. ### Implementation Details :construction: In 2023 OSes, `URL` now follows RFC 3986 and automatically encodes URL components with proper escaping. This reduces the cases where strings can't properly be converted to `URL`s automatically, so new test values had to be found. Using an empty string brings back the old behavior. > Fixed: For apps linked on or after iOS 17 and aligned OS versions, URL parsing has updated from the obsolete RFC 1738/1808 parsing to the same RFC 3986 parsing as URLComponents. This unifies the parsing behaviors of the URL and URLComponents APIs. Now, URL automatically percent- or IDNA-encodes invalid characters to help create a valid URL. > To check if a urlString is strictly valid according to the RFC, use the new URL(string: urlString, encodingInvalidCharacters: false) initializer. This init leaves all characters as they are and will return nil if urlString is explicitly invalid. (93368104)

view details

push time in 18 hours

push eventAlamofire/Alamofire

Jon Shier

commit sha 98c28e683253e920f5220d4456c5e4a6da7aa941

Update URL Conversion Tests (#3734) ### Goals :soccer: This PR updates some failing tests for the first Xcode 15 beta. ### Implementation Details :construction: In 2023 OSes, `URL` now follows RFC 3986 and automatically encodes URL components with proper escaping. This reduces the cases where strings can't properly be converted to `URL`s automatically, so new test values had to be found. Using an empty string brings back the old behavior. > Fixed: For apps linked on or after iOS 17 and aligned OS versions, URL parsing has updated from the obsolete RFC 1738/1808 parsing to the same RFC 3986 parsing as URLComponents. This unifies the parsing behaviors of the URL and URLComponents APIs. Now, URL automatically percent- or IDNA-encodes invalid characters to help create a valid URL. > To check if a urlString is strictly valid according to the RFC, use the new URL(string: urlString, encodingInvalidCharacters: false) initializer. This init leaves all characters as they are and will return nil if urlString is explicitly invalid. (93368104)

view details

push time in 18 hours

push eventAlamofire/Alamofire

Jon Shier

commit sha e1c4d94a97c8df214de04857ff46690ab6b681a1

Add beta CI.

view details

push time in 19 hours

startedAlamofire/Alamofire

started time in 19 hours

startedAlamofire/Alamofire

started time in 20 hours

PR opened Alamofire/Alamofire

Update URL Conversion Tests

Goals :soccer:

This PR updates some failing tests for the first Xcode 15 beta.

Implementation Details :construction:

In 2023 OSes, URL now follows RFC 3986 and automatically encodes URL components with proper escaping. This reduces the cases where strings can't properly be converted to URLs automatically, so new test values had to be found. Using the empty string brings back the old behavior.

Fixed: For apps linked on or after iOS 17 and aligned OS versions, URL parsing has updated from the obsolete RFC 1738/1808 parsing to the same RFC 3986 parsing as URLComponents. This unifies the parsing behaviors of the URL and URLComponents APIs. Now, URL automatically percent- or IDNA-encodes invalid characters to help create a valid URL. To check if a urlString is strictly valid according to the RFC, use the new URL(string: urlString, encodingInvalidCharacters: false) initializer. This init leaves all characters as they are and will return nil if urlString is explicitly invalid. (93368104)

+14 -6

1 commit in Alamofire/Alamofire/tree/2023-test-failures Alamofire/Alamofire/tree/master

0 comment

3 changed files

pr created time in 20 hours

create barnchAlamofire/Alamofire

branch : 2023-test-failures

created branch time in 20 hours

startedAlamofire/Alamofire

started time in 21 hours

startedAlamofire/Alamofire

started time in 21 hours