profile
viewpoint
Automattic Automattic Worldwide https://automattic.com We are passionate about making the web a better place.

Automattic/antiscroll 1078

OS X Lion style cross-browser native scrolling on the web that gets out of the way.

Automattic/ad-code-manager 108

Easily manage the ad codes that need to appear in your templates

Automattic/advanced-post-cache 53

All up in your WP_Query, caching the things.

Automattic/android-wordpress-com-rest 34

WordPress.com REST Client for Android apps.

Automattic/abacus 28

Abacus: Automattic's Experimentation Platform UI

Automattic/Adbusters 28

A WordPress plugin that loads a set of iframe busters for popular ad networks

Automattic/action-required-review 24

[READ ONLY] GitHub Action that will check if all review requirements are met for a PR. This repository is a mirror, for issue tracking and development head to: https://github.com/automattic/jetpack

Automattic/aggregator 19

Synchronise posts between blogs in a multisite network.

Automattic/a8c-ci-toolkit-buildkite-plugin 17

A caching plugin that can be invoked from your build script.

Automattic/action-commit-to-branch 16

GitHub action that will commit the result to an input branch

create barnchAutomattic/themes

branch : cleanup/block-canvas-remove-table-css

created branch time in 4 hours

PR closed Automattic/wp-calypso

Hide variant picker for Akismet Personal plans [Status] Needs Review

Proposed Changes

This diff removes the product variant picker for Akismet Personal plans, as we are only planning on selling yearly plans for now

Notes:

  • There is a bug right now where a yearly plan is pro-rated due to wpcom detecting the first Akismet Personal subscription ever purchased and reducing the price based on that. A fix for that is in progress
  • The variant picker will still currently show for Akismet Personal Monthly plans, but this product will automatically be removed from the cart when some new validation is added soon: 1201210512993648-as-1204264517688090/f

Testing Instructions

  1. Checkout this branch
  2. Sandbox public-api.wordpress.com
  3. Make sure you are using the Store Sandbox
  4. Head to http://calypso.localhost:3000/checkout/akismet/ak_personal_yearly:-q-36
  5. Make sure the display of the pricing is not confusing and makes sense (this is where the pro-rated discount mentioned in the Proposed Changes section will show up, you can ignore this aspect) image
  6. Make sure the variant picker does not show up
  7. Go to http://calypso.localhost:3000/me/purchases and find your new subscription
  8. Open the manage purchase page associated with it and make sure everything looks good image

Pre-merge Checklist

  • [ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
  • [ ] Have you written new tests for your changes?
  • [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • [ ] Have you checked for TypeScript, React or other console errors?
  • [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?
+54 -6

5 comments

6 changed files

CodeyGuyDylan

pr closed time in 4 hours

push eventAutomattic/wp-calypso

vykes-mac

commit sha e3240ec7e220960ceebcd2ac3a44c4ce92729dd8

add toolbar with date range picker

view details

vykes-mac

commit sha 913397f4a526215cbc9d54c03d0409419b166182

fetch logs when date range is selected

view details

vykes-mac

commit sha 99e55391a17d2922c3027f2ac245491d9d6c4702

fix test by mocking window.MatchMedia

view details

vykes-mac

commit sha d2cf9415bb3e5d99377b2e4851ba1a09d6b38228

add time format to DateRange picker to allow users to specify time as part of the date

view details

vykes-mac

commit sha 9bb3a08b64166a05c6647940fb196bb56f72d7c3

keep time the same when user changes day.

view details

vykes-mac

commit sha 7ad5ce11d1c49e58c59246cdf96437030f064f7b

Merge branch 'add/date-range' of github.com:Automattic/wp-calypso into add/date-range

view details

push time in 4 hours

delete branch Automattic/jetpack

delete branch : fix/jetpack-social-sig-enabling-automatically-on-existing-posts

delete time in 4 hours

push eventAutomattic/jetpack

Daniel Post

commit sha dd7769345133ffe78448b9f0c042298c8f6ddfe3

Jetpack Social: Prevent SIG from enabling itself automatically on existing posts (#29659) * [not verified] Prevent SIG from enabling itself automatically on existing posts * [not verified] Update meta on server instead * [not verified] Improve setting check * [not verified] Set the default value for SIG enabled based on the post_status. * [not verified] Pass in the blog ID when checking if SIG is enabled. We should be able to remove this when we merge the refactor of the init code. * [not verified] Remove unnecessary changelog. * [not verified] Swap to using the new feature check method. * [not verified] Refactor the method to filter the metadata. * [not verified] Prevent tokens from being generated when importing. * [not verified] Rework the default metadata hook to cope with $single. Depending on whether the metadata is retrieved with `single` set, the default metadata needs to get filtered differently. This also broke the tests. So they had to be reworked too. It's thrown up a bug with WorDBless as well, so I've had to skip a test. * [not verified] Remove the unnecessary call to tearDown. * [not verified] Update the test skipped comment. * Flip the logic, so SIG is disabled by default. * Update the SIG setting to enabled for new posts. * Explicitly update the metadata when it's a new, uneditted, post. * Reorder checks before generating the token. * Don't enable SIG unless it's enabled in settings. --------- Co-authored-by: Paul Bunkham <paul@dobit.co.uk>

view details

push time in 4 hours

PR merged Automattic/jetpack

Jetpack Social: Prevent SIG from enabling itself automatically on existing posts [Status] In Progress [Status] Needs Team Review RNA [Package] Publicize [JS Package] Publicize Components [Status] Needs Test Review

<!--- Provide a general summary of your changes in the Title above --> <!-- Would you like this feature to be tested by Beta testers? Please add testing instructions to projects/plugins/jetpack/to-test.md in a new commit as part of your PR. --> <!-- a12s: If you have an expected version that you're aiming for the PR to add, please use the Milestone field to communicate it. If you leave it blank, that indicates there isn't a preference. -->

Proposed changes:

<!--- Explain what functional changes your PR includes --> This PR fixes an issue where Social Image Generator was being enabled automatically for existing posts, by relying on Gutenberg to update the post meta rather than doing it a hook after saving the post. I've explained the changes in detail in the code since I think the context is helpful.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

<!-- If you're an Automattician, include a shortlink to the p2 discussion with Jetpack Product here. --> <!-- Make sure any changes to existing products have been discussed and agreed upon --> 1202816441505085-as-1204236160532606/f

Does this pull request change what data or activity we track or use?

<!--- If so, please add the "[Status] Needs Privacy Updates" label and explain what changes there are. --> <!--- Check existing Jetpack support documents for a preview of the information we need. --> No.

Testing instructions:

<!-- If you were reviewing this PR, how would you like the instructions to be presented? --> <!-- Please include detailed testing steps, explaining how to test your change. --> <!-- Bear in mind that context you working on is not obvious for everyone. --> <!-- Adding "simple" configuration steps will help reviewers to get to your PR as quickly as possible. --> <!-- "Before / After" screenshots can also be very helpful when the change is visual. -->

  • Make sure Social Image Generator is enabled for your site.
  • Create a new post and make sure the Social Image Generator toggle is enabled.
  • Publish it or save it as a draft.
  • Check that the meta was saved correctly: get_post_meta( POST_ID ) in the shell
  • Now, delete the post meta (delete_post_meta( POST_ID, '_wpas_options' ) and open the editor for the post.
  • Check that the toggle is disabled.
  • Change the post title or content and save it.
  • Check the meta again, and make sure that SIG is now disabled.
  • Repeat this process for the Classic Editor. In this case, SIG should always be disabled.
+65 -36

3 comments

7 changed files

danielpost

pr closed time in 4 hours

PullRequestReviewEvent

pull request commentAutomattic/jetpack

Jetpack Social: Prevent SIG from enabling itself automatically on existing posts

I can't approve this because I opened the PR but this works as expected!

danielpost

comment created time in 4 hours

PR closed Automattic/woocommerce-payments

[POC] Use Store API Token for requests to the Store API

Fixes #

Changes proposed in this Pull Request

<!-- Title: A descriptive, yet concise, title. -->

<!-- Description: Write a brief summary about this PR. As you compose your summary, consider each of these questions and address them if appropriate. Why is this change needed? What does this change do? Were there other solutions you considered? Why did you choose to pursue this solution? Describe any trade-offs you might have had to make. -->

<!-- Questions for PR author:

  • How can this code break?
  • What are we doing to make sure this code doesn't break? -->

<!-- Images or gifs: Include before and after screenshots or gifs/videos when it makes sense. -->

Testing instructions

<!-- Testing instructions: How should this be tested and how can a reviewer test the end-user functionality? Are there known issues that you plan to address in a future PR? Are there any side effects that readers should be aware of? -->

<!-- Add as many details as possible to help others reproduce the issue and test the fix. "Before / After" screenshots can also be very helpful when the change is visual. -->


  • [ ] Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • [ ] Covered with tests (or have a good reason not to test in description ☝️)
  • [ ] Tested on mobile (or does not apply)

Post merge

<!-- Make sure you edit the page for the current release when adding testing instructions. We often create a blank page ahead of time for the next release. If this PR need not be QA tested, edit to 'QA Testing Not Applicable' -->

+33 -1

4 comments

1 changed file

asumaran

pr closed time in 4 hours

pull request commentAutomattic/jetpack

Fix post meta import issue

I'm not sure how you would map those names back but also I don't think this needs to run unless an import is happening, otherwise it will interfere with how meta is saved in the block editor.

This runs only when the import endpoints is called. It does not intercept core REST endpoints.

ouikhuan

comment created time in 4 hours

push eventAutomattic/jetpack

Damián Suárez

commit sha 39dfe8b9924b3d51d6b5d0fec8499cf4c753ce5d

refresh the player once image generated

view details

Damián Suárez

commit sha 9abf3c474faddd23eff0c28d7f52040356a66450

increase delay to poll to 5s

view details

push time in 4 hours

pull request commentAutomattic/wp-calypso

Hide variant picker for Akismet Personal plans

Issue created here (should be a very easy fix, I think): https://github.com/Automattic/payments-shilling/issues/1508

D106310-code may make this PR unnecessary.

CodeyGuyDylan

comment created time in 4 hours

push eventAutomattic/node-canvas

Caleb Hearon

commit sha 8e9ace1807495d9f9053aa94a5cefd060e1509f1

mess w node

view details

push time in 4 hours

push eventAutomattic/vip-go-mu-plugins-built

rebeccahum

commit sha a508121aea9d77893adc2c0b5c91b34da4168384

Built from vip-go-mu-plugins@375e8344474379c4262a5317b4c3f3d6a0674821

view details

push time in 4 hours

startedAutomattic/simplenote-electron

started time in 4 hours

delete branch Automattic/vip-go-mu-plugins

delete branch : search/add-timestamp-to-cli-get-last-indexed-post-id

delete time in 4 hours

push eventAutomattic/vip-go-mu-plugins

Rebecca Hum

commit sha 375e8344474379c4262a5317b4c3f3d6a0674821

Search: Improve get-last-indexed-post-id to include timestamp for debugging (#4266) * Search: Improve get-last-indexed-post-id to include timestamp for debugging purposes * Remove removal of option after indexing has completed * Revert "Remove removal of option after indexing has completed" This reverts commit 7c7e99b28104450c09738fb4ba5686c70fbbba14.

view details

push time in 4 hours

PR merged Automattic/vip-go-mu-plugins

Search: Improve get-last-indexed-post-id to include timestamp for debugging [Component] Search [Status] Needs Docs

Description

If an index gets interrupted, we usually use wp vip-search get-last-indexed-post-id to check the last post ID. This change adds the timestamp and changes it to a JSON format:

wp vip-search get-last-indexed-post-id                                                                                             
{"post_id":979,"time":"2023-03-24 18:15:37"}

Changelog Description

Plugin Updated: Enterprise Search

Add timestamp to wp vip-search get-last-indexed-post-id

Checklist

Please make sure the items below have been covered before requesting a review:

  • [x] This change works and has been tested locally (or has an appropriate fallback).
  • [ ] This change works and has been tested on a Go sandbox.
  • [ ] This change has relevant unit tests (if applicable).
  • [ ] This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • [ ] This change has relevant documentation additions / updates (if applicable).
  • [x] I've created a changelog description that aligns with the provided examples.

Steps to Test

  1. Kick off an index with wp vip-search index
  2. While the index is happening, in another window, do wp vip-search get-last-indexed-post-id and you should see a format similar to Description
+6 -2

4 comments

2 changed files

rebeccahum

pr closed time in 4 hours

push eventAutomattic/wp-calypso

escapemanuele

commit sha ee8289340dd2324653194d53908f62a2424c53da

Subscribers step

view details

push time in 4 hours

issue commentAutomattic/wp-calypso

Plans Grid: Toggle is full width on mobile screen

On my end, the styling also changed.

image

ebinnion

comment created time in 4 hours

push eventAutomattic/jetpack-production

nunyvega

commit sha b44807b211a1915a8f9fcd0e7844a56121b158db

JITM: Fix button overflow when text length is too big (#29749) * fix button overflow * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4545615467

view details

push time in 4 hours

push eventAutomattic/jetpack-storybook

nunyvega

commit sha 439e837f8ea5a81877461817028ebcf5aff13efc

JITM: Fix button overflow when text length is too big (#29749) * fix button overflow * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4545615467

view details

push time in 4 hours

push eventAutomattic/jetpack-search-plugin

nunyvega

commit sha 31fdfcd2f09f5e960d15b84d9e93cace4b4a7c17

JITM: Fix button overflow when text length is too big (#29749) * fix button overflow * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4545615467

view details

push time in 4 hours

push eventAutomattic/jetpack-boost-production

nunyvega

commit sha e4ffb745e96f2f3f19397c77dc8a0d126eecd4db

JITM: Fix button overflow when text length is too big (#29749) * fix button overflow * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4545615467

view details

push time in 4 hours

push eventAutomattic/jetpack-social-plugin

nunyvega

commit sha 4e39888d32589e1fcf493c357916d0295fb2bb26

JITM: Fix button overflow when text length is too big (#29749) * fix button overflow * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4545615467

view details

push time in 4 hours

push eventAutomattic/jetpack-protect-plugin

nunyvega

commit sha 8209ca7780177b9e9783bf70f82910b359e0eada

JITM: Fix button overflow when text length is too big (#29749) * fix button overflow * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4545615467

view details

push time in 4 hours

push eventAutomattic/wpcom-migration

nunyvega

commit sha 10f74778d0d61ecd57dd176c73b5e41aa43db0cb

JITM: Fix button overflow when text length is too big (#29749) * fix button overflow * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4545615467

view details

push time in 4 hours

push eventAutomattic/jetpack-starter-plugin

nunyvega

commit sha 168ed63d72dad46ad9c5c5637532aef9e350ac77

JITM: Fix button overflow when text length is too big (#29749) * fix button overflow * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4545615467

view details

push time in 4 hours

push eventAutomattic/jetpack-backup-plugin

nunyvega

commit sha 69e615831d2b24d183d0611373b95dcac3df8b99

JITM: Fix button overflow when text length is too big (#29749) * fix button overflow * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4545615467

view details

push time in 4 hours

push eventAutomattic/jetpack-videopress-plugin

nunyvega

commit sha 0a59c04aef4280f7b79f55fe3819968e2fc332c2

JITM: Fix button overflow when text length is too big (#29749) * fix button overflow * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/4545615467

view details

push time in 4 hours

more