Jarcho/d2dx 15
D2DX is a complete solution to make Diablo II run well on modern PCs, with high fps and better resolutions.
Testing library for cdylib projects in rust
Rust bindings to Windows API
A template to use when setting up to create packages both manual and automatic
TLDatLexer is a plugin for Notepad++ which adds extended support for Torchlight data files.
A crate for mucking around with piles of bytes
The Rust package manager
A somewhat idiomatic Rust wrapper for libclang.
issue commentJarcho/d2dx
I guess it's the same issue that lead to me disabling smoothing in multiplayer originally then. I had never seen it crash single player though.
comment created time in 3 days
Pull request review commentrust-lang/rust-clippy
[`let_with_type_underscore`]: Don't emit on locals from procedural macros
impl LateLintPass<'_> for UnderscoreTyped { if let TyKind::Infer = &ty.kind; // that type is '_' if local.span.ctxt() == ty.span.ctxt(); then {- span_lint_and_help(cx,+ let underscore_span = ty.span.with_lo(local.pat.span.hi());+ let snippet = snippet(cx, underscore_span, ": _");++ // NOTE: Using `is_from_proc_macro` on `init` will require that it's initialized,+ // this doesn't. Alternatively, `WithSearchPat` can be implemented for `Ty`+ if !snippet.trim().starts_with(':') && !snippet.trim().ends_with('_') {
You're doing extra work here by checking for : _ and not just _.
comment created time in 3 days
issue commentJarcho/d2dx
New test version. Can you run it and upload d2fps.log after the game crashes.
Going by the backtrace you posted the player is ending up without a room somehow. I don't have that part of the code reversed so I'm not too sure how that's happening.
comment created time in 3 days
issue commentJarcho/d2dx
I have no idea how you're triggering that. Over a hundred TP's while running around and I still haven't gotten it to crash.
comment created time in 4 days
issue commentJarcho/d2dx
Still can't get it with that. Can you upload the whole save and not just the character.
comment created time in 4 days
issue commentJarcho/d2dx
Couple quick questions
- Single of multi player? (looks like single)
- Does the crash only happen when teleporting in one direction, or both?
comment created time in 4 days
issue commentJarcho/d2dx
New release. Multiplayer should be "working" (as in doesn't crash), but needs testing for how motion smoothing actually behaves. Mainly needs testing around how motion smoothing combines with network latency.
comment created time in 10 days
push eventJarcho/d2-rs
commit sha 833f129c1383aa88b7d7aeca46ab5fb7a8ae51a9
Use structs for some globals
commit sha 4038a434b0a63ba2f222a6e2d0909619030ef3da
Enable multiplayer motion smoothing
push time in 10 days
issue commentrust-lang/rust-clippy
As is there's not enough info in the report. You're first example is incomplete and doesn't reproduce the error and the second example is correctly linted.
comment created time in 10 days
issue commentrust-lang/rust-clippy
Loops are capable of resulting in a value via break expr.
comment created time in 11 days
pull request commentrust-lang/rust-clippy
[`unused_async`]: do not consider `await` in nested `async` blocks as used
Thank you. @bors r+
comment created time in 11 days
issue commentJarcho/d2dx
Checked into PD2 crashing. The crash is caused by PD2 patching over memory d2fps already patched. Fixing this would require PD2 to not apply their fps patches.
comment created time in 11 days
issue commentJarcho/d2dx
Main post updated. Nearly all versions are now supported.
comment created time in 11 days
push eventJarcho/d2-rs
commit sha 70ed319e22e1911d5a1196b72fd075a23a85a9f7
Finish support for v1.14c
push time in 11 days
issue closedrust-lang/rust-clippy
What it does
It is easier to illustrate this as a lint formed of multiple lints.
-
[x]
test_outside_tests_module: Warns when a unit test is outside a tests module. -
[ ]
unflagged_tests_module: Warns when a module namedtestsis not flagged with#[cfg(test)]. -
[ ]
non_eof_tests_module: Warns when a module namedtestsis not at the end of a file.
Lint Name
strict_tests_module
Category
style, pedantic
Advantage
- Enforces the idiomatic style of unit tests.
- Allows tools like
grcovto correctly exclude unit tests from coverage with--excl-start "mod tests".
Drawbacks
- Tools like
bindgenoften include tests outside test modules. This would warn on this case.
Example
#[test]
fn my_test() { /* ... */ }
#[cfg(test)]
mod tests { /* ... */ }
Could be written as:
#[cfg(test)]
mod tests {
#[test]
fn my_test() { /* ... */ }
/* ... */
}
mod tests { /* ... */ }
Could be written as:
#[cfg(test)]
mod tests { /* ... */ }
#[cfg(test)]
mod tests { /* ... */ }
fn an_item_after() { /* ... */ }
Could be written as:
fn an_item_after() { /* ... */ }
#[cfg(test)]
mod tests { /* ... */ }
<!-- TRIAGEBOT_START -->
<!-- TRIAGEBOT_ASSIGN_START -->
<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"blyxyas"}$$TRIAGEBOT_ASSIGN_DATA_END -->
<!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->
closed time in 11 days
JonathanWoollett-Light
push eventJarcho/d2-rs
commit sha 83af3c03e830048eded5d81f7d9ebeb7612667d2
Add support for v1.07
commit sha 75e008d9a7e47fca5225e7ec25664bb7f467caf2
Add support for v1.08
commit sha e617024dc9dc2e66b1dc6f1d25ac984d5e57cdf2
Add support for v1.09 and v1.09b
push time in 12 days
Pull request review commentrust-lang/rust-clippy
[`arithmetic_side_effects`] Fix #10792
impl<'a, 'tcx> ConstEvalLateContext<'a, 'tcx> { pub fn miri_to_const<'tcx>(tcx: TyCtxt<'tcx>, result: mir::ConstantKind<'tcx>) -> Option<Constant> { use rustc_middle::mir::interpret::ConstValue; match result {- mir::ConstantKind::Val(ConstValue::Scalar(Scalar::Int(int)), _) => {- match result.ty().kind() {- ty::Bool => Some(Constant::Bool(int == ScalarInt::TRUE)),- ty::Uint(_) | ty::Int(_) => Some(Constant::Int(int.assert_bits(int.size()))),- ty::Float(FloatTy::F32) => Some(Constant::F32(f32::from_bits(- int.try_into().expect("invalid f32 bit representation"),- ))),- ty::Float(FloatTy::F64) => Some(Constant::F64(f64::from_bits(- int.try_into().expect("invalid f64 bit representation"),- ))),- ty::RawPtr(_) => Some(Constant::RawPtr(int.assert_bits(int.size()))),- // FIXME: implement other conversions.- _ => None,- }+ mir::ConstantKind::Val(ConstValue::Scalar(Scalar::Int(int)), _) => match result.ty().kind() {+ ty::Adt(_, _) => Some(Constant::Int(int.assert_bits(int.size()))),
Would be better to add a variant to Constant to hold struct types and then resolve fields as they come up. The variant can just be a reference to an allocation.
comment created time in 12 days
push eventJarcho/d2-rs
commit sha 3b705f01eabce2c4e741195728e7b5f7dbb1a9cc
Finish support for v1.11
commit sha 778f36ecaacd005d709a0568bfa4ed6d97e1ba07
Finish support for v1.11b
push time in 13 days
push eventJarcho/d2-rs
commit sha 8b0196e6f6bd6d8deda2602ceab9ded447231219
Add support for v1.06
commit sha 04b3fc877f890bf64f4efe9c38eb2447ceefa73e
Shorten teleport interception hook
commit sha b531fd38443f92f1e55f484049a5711bda6c4de9
Add support for v1.06b
push time in 13 days
push eventJarcho/d2-rs
commit sha 07e5b480be7a98b86f799eea2ef8da0ff130e8aa
Add support for v1.04c
commit sha 4f3d2a33ce60efcb56d7e41319b1e40dd0dc5272
Add support for v1.05 and v1.05b
commit sha 3cf01ce09f338606125ad85e0236c2d6b115bffe
Add support for v1.06
push time in 13 days
push eventJarcho/d2-rs
commit sha 98d1f6744e7dd181c9926eca5f040afffaf87e16
Add support for 1.03
commit sha 2517424d86c746c89157ce281e6d20e58494c75a
Add support for v1.04b
push time in 13 days
push eventJarcho/d2-rs
commit sha 511d0d9fce1b39772c573037ad3d15ac621aafa4
Use ordinals when possible
push time in 14 days
push eventJarcho/d2-rs
commit sha 6c902db03d64f50d26fea1a436fc9d144d1927fc
Add support for 1.02
push time in 14 days
issue commentJarcho/d2dx
That's running the game at ~120 fps. There were a few fluctuations, but the average is just slightly under 120. Given that this is the amount of time passed between present calls there isn't a more accurate measurement of what the game is drawing. If you're getting a higher number then it's from something else.
comment created time in 14 days
Pull request review commentrust-lang/rust-clippy
[`unused_async`]: do not consider `await` in nested `async` blocks as used
declare_lint_pass!(UnusedAsync => [UNUSED_ASYNC]); struct AsyncFnVisitor<'a, 'tcx> { cx: &'a LateContext<'tcx>, found_await: bool,+ /// Also keep track of `await`s in nested async blocks so we can mention+ /// it in a note+ found_await_in_async_block: bool,
I'm not against doing this, but it should be keeping track of the span as well. Just the first occurrence is fine.
comment created time in 14 days
pull request commentrust-lang/rust-clippy
Fix missing block for unsafe code
@bors retry
comment created time in 14 days
pull request commentrust-lang/rust-clippy
Fix `diverging_sub_expression` not checking body of block
Clippy has a no merge commit policy. You'll have to rebase your changes instead.
comment created time in 14 days