Check for existing issues

• [X] Completed

Describe the feature

Currently Zed only offers type expansion if you hover over the variable. One of my favorite features of CLion is the inline type expansion. Would it be possible to add this to Zed?

If applicable, add mockups / screenshots to help present your vision of the feature

Check for existing issues

• [X] Completed

Describe the feature

It takes up two lines of code at the top of the screen and isn't necessary in my workflow. I would appreciate an option to hide it, or at least move its contents into the status bar which is mostly empty (similar to JetBrains New UI).

If applicable, add mockups / screenshots to help present your vision of the feature

No response

all this

There's nothing but the ability to open a standalone file with code, as code foo.rs Works for me still:

Due to impl limitations described above, all consequent standalone file opens in the same editor won't work.

Looks like a duplicate of https://github.com/zed-industries/community/issues/206 ?

Check for existing issues

• [X] Completed

Describe the feature

Would be nice to be able to duplicate a file from the sidebar. The sidebar currently supports both copy & paste but combining both steps into one would be a great addition. Thanks

If applicable, add mockups / screenshots to help present your vision of the feature

No response

Duplicate of https://github.com/zed-industries/community/issues/276

Check for existing issues

• [X] Completed

Describe the feature

Now you can use cmd-p to open the file, but you can't specify the specified location to open the file. Can you support symbols : and @

For example:

:50 go to current file line 50 :50,5 go to current file line 50, character 5

@fun go to current file function fun

test.ts:50 go to test.ts file line 50 test.ts:50,5 go to test.ts file line 50, character 5 test.ts@fun go to test.ts file function fun

Refer to vscode for details

If applicable, add mockups / screenshots to help present your vision of the feature

No response

Looks like duplicate of https://github.com/zed-industries/community/issues/557

In v0.87.0 , file finder will support path_like:row:column notation when opening a file, which covers most of this issue. Additional, non-colon, separators like ,, @ are not supported currently, but that could go into a separate issue with a less generic title.

It's a global, editor setting that's supposed to be in the root of the settings, something like this:

{
    "features": {
        "copilot": true
    },
    "theme": "Ayu Mirage",
    "format_on_save": "on",
    "show_whitespaces": "all",
    "soft_wrap": "editor_width",
    "tab_size": 4
}

This is being landed as part of v0.86.0 (apologies for the silent preliminary closing before)

https://github.com/neondatabase/neon/pull/4090 was not supposed to address this issue, unless done accidentally.

Check for existing issues

• [X] Completed

Describe the feature

When closing an unsaved file, Zed shows this dialog:

It would be better to have the Don't Save button outlined (like below) because then every button is one keypress away:

• Cancel: Escape
• Don't Save: Space
• Save: Enter

If applicable, add mockups / screenshots to help present your vision of the feature

No response

This PR should fix the CI issues. Basically making clippy happy again.

When this is merged could you perhaps make a new release?

Hey, thank you for spotting this originally. Finally, this is fixed in https://github.com/vorot93/tokio-tar/pull/21 and now we can think of a new release.

I see to lack the credentials for that, so a separate issue for that would be good to create?

One more left unfixed:

    Checking tokio-tar v0.3.0 (/Users/someonetoignore/work/other/tokio-tar)
error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing
   --> src/archive.rs:429:5
    |
429 |     drop(header);
    |     ^^^^^^^^^^^^
    |
note: argument has type `&mut header::Header`
   --> src/archive.rs:429:10
    |
429 |     drop(header);
    |          ^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref
    = note: `#[deny(clippy::drop_ref)]` on by default

Superseded by https://github.com/vorot93/tokio-tar/pull/21

Could not reproduce the CI test error locally (mac, Linux) and style fixes seem unrelated.

Could not reproduce the CI test error locally (mac, Linux) and style fixes seem unrelated.

Some workflows use tar streaming over TCP-based protocols and would love to place the termination bytes themselves, when the right moment comes.

The PR provides a simple way to do so:

• adds a skip_termination method to allow all Builder::new-created instances to do so
• adds a non-'static Builder::new_non_terminated constructor, and allows using all builder methods for it too

For a few reasons:

• This allows removing the 'static requirement on the writer.

• There was no way to abort writing the archive without writing the termination sections. If an error happens while building the archive, it's probably best to not write the termination sections, so that the incomplete archive doesn't look complete.

• Writing the termination sections in a separate task made it indeterminate when exactly it happened. It could happen long after the Builder was dropped.

Writing the termination sections on drop made sense in the original sync 'tar' crate, where it was more well-defined, but in async world it's better to require the programmer to be explicit about finishing it.

This is an incompatible change, if your application doesn't call finish or into_inner explicitly.

This PR does the same as https://github.com/vorot93/tokio-tar/pull/17 , but also changes the way things worked by default — with the new library version, old code stops adding a termination to builder implicitly.

Might not be a good thing to do right now, I'd start with backward-compatible approach from https://github.com/vorot93/tokio-tar/pull/17 first