profile
viewpoint

apple/darwin-xnu 10706

Legacy mirror of Darwin Kernel. Replaced by https://github.com/apple-oss-distributions/xnu

apple/coremltools 3387

Core ML tools contain supporting tools for Core ML model conversion, editing, and validation.

apple/cups 1692

Apple CUPS Sources

apple/ccs-calendarserver 467

The Calendar and Contacts Server.

apple/ARKitScenes 466

This repo accompanies the research paper, ARKitScenes - A Diverse Real-World Dataset for 3D Indoor Scene Understanding Using Mobile RGB-D Data and contains the data, scripts to visualize and process assets, and training code described in our paper.

apple/device-management 336

Device management schema data for MDM.

apple/example-package-dealer 295

Example package for use with the Swift Package Manager

apple/example-package-playingcard 288

Example package for use with the Swift Package Manager

apple/example-package-fisheryates 179

Example package for use with the Swift Package Manager

apple/example-package-deckofplayingcards 171

Example package for use with the Swift Package Manager

startedapple/homebrew-apple

started time in an hour

startedapple/homebrew-apple

started time in an hour

startedapple/homebrew-apple

started time in an hour

push eventapple/llvm-project

Marco Elver

commit sha 33388d8c0b676009bcb4802d5db82865157cb41e

Revert "[compiler-rt] Allow 3 simultaneous interceptors on Linux" This reverts commit 57882fe76e1826593cd0e53f73484b184c5007c4. This reverts commit 74b0ac571b5facee3c8038d21ed71d7a29ee1098. Breaks various build bots.

view details

git apple-llvm automerger

commit sha 053a7221be1654afeb46c444510c50150abc9db5

Merge commit '33388d8c0b67' from llvm.org/main into next

view details

push time in an hour

push eventapple/llvm-project

Marco Elver

commit sha 33388d8c0b676009bcb4802d5db82865157cb41e

Revert "[compiler-rt] Allow 3 simultaneous interceptors on Linux" This reverts commit 57882fe76e1826593cd0e53f73484b184c5007c4. This reverts commit 74b0ac571b5facee3c8038d21ed71d7a29ee1098. Breaks various build bots.

view details

git apple-llvm automerger

commit sha 053a7221be1654afeb46c444510c50150abc9db5

Merge commit '33388d8c0b67' from llvm.org/main into next

view details

push time in an hour

push eventapple/llvm-project

Juan Manuel MARTINEZ CAAMAÑO

commit sha abe6ecd7e5f5bc4e57fb6b530e3ea4811d06e4b9

[AsmPrinter][AMDGPU] Generate uwtable entries in .eh_frame Consider only targets where `MCAsmInfo::ExceptionsType == ExceptionHandling::None` and that support CFI (when `MCAsmInfo::UsesCFIForDebug` is set to true): currently, only AMDGPU. This patch enables the emission of CFI information in the .eh_frame section when the uwtable attribute is present on a function. Before, we could generate CFI information for debugging puproses only. This patch prepares AMDGPU to support collecting GPU stack traces in the future. I did a first implementation (https://reviews.llvm.org/D139024) but at the time I had not realized that no other platform used `UsesCFIForDebug`. Reviewed By: scott.linder Differential Revision: https://reviews.llvm.org/D151806

view details

git apple-llvm automerger

commit sha 2dee195f83352e85479111e8c64f93beec7a0451

Merge commit 'abe6ecd7e5f5' from llvm.org/main into next

view details

push time in an hour

push eventapple/llvm-project

Kazu Hirata

commit sha f705a60eb735376561f2c20863e5299398c75b17

[ProfileData] Remove unused declaration getMemOPSizeRangeFromOption The corresponding function definition was removed by: commit 1ebee7adf8966ad9d2885c172a18104c94667061 Author: Hiroshi Yamauchi <yamauchi@google.com> Date: Fri Oct 2 13:00:40 2020 -0700

view details

Sam McCall

commit sha 9e932e08a8300f3366ace04ba8fda4946db406b9

[ADT] Fix DenseMapInfo<variant>::isEqual to delegate to DenseMapInfo, not == Differential Revision: https://reviews.llvm.org/D151557

view details

Aaron Ballman

commit sha 07028acacfd2b5dd6633814db690e5de8e37b40d

Silence a "not all control paths return a value" warning; NFC

view details

Vy Nguyen

commit sha 7e5f4ed5565892e33d7f2a504e8345459d5235e5

[lld-macho]Ensure canonicalization happen even for "skipped" referent sections. Details: See bug report: https://github.com/llvm/llvm-project/issues/63039 Differential Revision: https://reviews.llvm.org/D151824

view details

Aart Bik

commit sha e2167d89dba0a276ff756b80b5f4a1ebcb83a611

[mlir][sparse] refine absent branch feeding into custom op Document better that unary/binary may only feed to the output or the input of a custom reduction (not even a regular reduction since it may have "no value"!). Also fixes a bug when present branch is empty and feeds into custom reduction. Reviewed By: Peiming Differential Revision: https://reviews.llvm.org/D152224

view details

Simon Pilgrim

commit sha 78de45fd4a902066617fcc9bb88efee11f743bc6

Revert rGab4b924832ce26c21b88d7f82fcf4992ea8906bb - [X86] X86FixupVectorConstantsPass - attempt to replace full width integer vector constant loads with broadcasts on AVX2+ targets Reverting while we address an existing issue exposed by this (Issue #63108)

view details

Nick Desaulniers

commit sha 8abbc17ff3b1390581600d1b9b37888f4b8ba50e

reland: [Demangle] make llvm::demangle take std::string_view rather than const std::string& As suggested by @erichkeane in https://reviews.llvm.org/D141451#inline-1429549 There's potential for a lot more cleanups around these APIs. This is just a start. Callers need to be more careful about sub-expressions producing strings that don't outlast the expression using `llvm::demangle`. Add a release note. Differential Revision: https://reviews.llvm.org/D149104

view details

Craig Topper

commit sha 45680acbbe403582c5ad05c7077c849208d0d7b6

[RISCV] Remove uses of RISCVII::hasMergeOp from RISCVDAGToDAGISel.cpp This property was intended to indicate when RISCVAsmPrinter should drop the tied source operand when converting to MCInst. Using it in RISCVDAGToDAGISel distorts what it intended for. This should remove some changes from D151850. Reviewed By: frasercrmck, asb Differential Revision: https://reviews.llvm.org/D152039

view details

Slava Zakharin

commit sha 4fbaefa246844bd2329712c9dbd20893d4d8f467

[flang][hlfir] Implemented addressing an element of a polymorphic array. The changes convert hlfir.designate to fir.array_coor/fir.embox to represent a subscripted element of a polymorphic array. The type information is conveyed via the fir.embox's source_box. Reviewed By: tblah Differential Revision: https://reviews.llvm.org/D152200

view details

Dirk MG Seynhaeve

commit sha f8b2cbf7ed4c900ffe1d2c30086aee73f7ab1e8a

[llvm] Small typo in the instruction comments of WithColor header Fix a small but misleading/confusing typo in the comments (which shows up in the doxygen documentation): Black -> BLACK (the enumeration is case-sensitive). Differential revision: https://reviews.llvm.org/D151598

view details

Simon Pilgrim

commit sha a279a09ab9524d1d74ef29b34618102d4b202e2f

Revert rG98061013e01207444cfd3980 - [X86] X86FixupVectorConstantsPass - attempt to replace full width fp vector constant loads with broadcasts on AVX+ targets Reverting while we address an existing issue exposed by this (Issue #63108)

view details

Elizabeth Andrews

commit sha c1401e9f3e7cfe10d5c8d7d040d66898bbc8ef39

[Clang][Sema] Fix access of friend class in local class Clang currently emits an error when a friend of a local class tries to access it's private data members. This patch fixes the bug. Differential Revision: https://reviews.llvm.org/D152195

view details

Alex Langford

commit sha 6836a47b7e6b57927664ec6ec750ae37bb951129

[DebugInfo] Add error checking around data extraction in DWARFAbbreviationDeclaration::extract In trying to hoist errors further up this callstack, I discovered that if the data in the debug_abbrev section is invalid entirely, the code that parses the debug_abbrev section may do strange or unpredictable things. The underlying issue is that DataExtractor will return a value of 0 when it encounters an error in extracting a LEB128 value. It's thus difficult to determine if there was an error just by looking at the return value. This patch aims to bail at the first sight of an error in the debug_abbrev parsing code. Differential Revision: https://reviews.llvm.org/D151755

view details

Tue Ly

commit sha b95ed8b6d9354fa10094b6425ecc84dd33682a58

[libc] Remove operator T from cpp::expected. The libc's equivalent of std::expected has a non-standard and non-explicit operator T - https://github.com/llvm/llvm-project/issues/62738 Reviewed By: sivachandra Differential Revision: https://reviews.llvm.org/D152270

view details

Med Ismail Bennani

commit sha 1e82b20118e31bd6c3844a84e03f701997a9b7ed

[lldb/Target] Add ability to set a label to targets This patch add the ability for the user to set a label for a target. This can be very useful when debugging targets with the same executables in the same session. Labels can be set either at the target creation in the command interpreter or at any time using the SBAPI. Target labels show up in the `target list` output, following the target index, and they also allow the user to switch targets using them. rdar://105016191 Differential Revision: https://reviews.llvm.org/D151859 Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

view details

Med Ismail Bennani

commit sha 6a9c3e611505b7637b46fbaacaf50362c97a263d

[lldb/Commands] Add support to auto-completion for user commands This patch should allow the user to set specific auto-completion type for their custom commands. To do so, we had to hoist the `CompletionType` enum so the user can access it and add a new completion type flag to the CommandScriptAdd Command Object. So now, the user can specify which completion type will be used with their custom command, when they register it. This also makes the `crashlog` custom commands use disk-file completion type, to browse through the user file system and load the report. Differential Revision: https://reviews.llvm.org/D152011 Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

view details

Med Ismail Bennani

commit sha 3bc0baf9d43967d828e2d311f6c0863e79158f07

[lldb/crashlog] Expand crash report file path before parsing This patch should fix a crash in the opening a crash report that was passed with a relative path. This patch expands the crash report path before parsing it and raises a `FileNotFoundError` exception if the file doesn't exist. Differential Revision: https://reviews.llvm.org/D152012 Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

view details

Med Ismail Bennani

commit sha e8966125e2812f08bf0f548bf576981025d44cbd

[lldb/Commands] Fix disk completion from root directory This patch should fix path completion starting from the root directory. To do so, this patch adds a special case when setting the search directory when the completion buffer points to the root directory. Differential Revision: https://reviews.llvm.org/D152013 Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

view details

Alex Langford

commit sha 11d61c079d4b4927efea42a38a27d4586887b764

Revert "[DebugInfo] Add error checking around data extraction in DWARFAbbreviationDeclaration::extract" This reverts commit 6836a47b7e6b57927664ec6ec750ae37bb951129. This breaks some bots, need to investigate.

view details

Arthur Eubanks

commit sha ec1998cd48b5e4cd7894dd024f990c31ddb58e6d

[lld][COFF] Don't handle an input file multiple times when retrying Follow up to D151815. Or else we properly handle the first instance of a file, then error out on the second instance of the same file. Reviewed By: rnk Differential Revision: https://reviews.llvm.org/D152198

view details

push time in an hour

startedapple/homebrew-apple

started time in an hour

push eventapple/llvm-project

Corentin Jabot

commit sha 22e95e0bf375660dd3d083b16a5d92c33559a4a3

[clang] Fix assertion while parsing an invalid for loop with multiple declarations followed by a colon. Fixes #63010 Reviewed By: shafik Differential Revision: https://reviews.llvm.org/D152009

view details

Matthias Springer

commit sha 1d153ea9aa0dbb9cc48f7fa882cdd3c65985cc52

[mlir][vector][transform] Add ApplyCastAwayVectorLeadingOneDimPatternsOp Expose the respective patterns as a transform op. Differential Revision: https://reviews.llvm.org/D152346

view details

push time in an hour

startedapple/homebrew-apple

started time in an hour

startedapple/sample-cloudkit-sync-engine

started time in an hour

startedapple/homebrew-apple

started time in an hour

startedapple/homebrew-apple

started time in an hour

startedapple/homebrew-apple

started time in an hour

startedapple/homebrew-apple

started time in an hour

push eventapple/llvm-project

Juan Manuel MARTINEZ CAAMAÑO

commit sha abe6ecd7e5f5bc4e57fb6b530e3ea4811d06e4b9

[AsmPrinter][AMDGPU] Generate uwtable entries in .eh_frame Consider only targets where `MCAsmInfo::ExceptionsType == ExceptionHandling::None` and that support CFI (when `MCAsmInfo::UsesCFIForDebug` is set to true): currently, only AMDGPU. This patch enables the emission of CFI information in the .eh_frame section when the uwtable attribute is present on a function. Before, we could generate CFI information for debugging puproses only. This patch prepares AMDGPU to support collecting GPU stack traces in the future. I did a first implementation (https://reviews.llvm.org/D139024) but at the time I had not realized that no other platform used `UsesCFIForDebug`. Reviewed By: scott.linder Differential Revision: https://reviews.llvm.org/D151806

view details

git apple-llvm automerger

commit sha 2dee195f83352e85479111e8c64f93beec7a0451

Merge commit 'abe6ecd7e5f5' from llvm.org/main into next

view details

push time in an hour

startedapple/ml-stable-diffusion

started time in an hour

PullRequestReviewEvent
PullRequestReviewEvent

startedapple/homebrew-apple

started time in an hour

Pull request review commentapple/swift-openapi-generator

[Docs] Document the Converter type and all the cases it needs to support

+# Converting between data and Swift types++Learn about the type responsible for convertering between raw data and Swift types.++## Overview++The [`Converter`](https://github.com/apple/swift-openapi-runtime/blob/main/Sources/OpenAPIRuntime/Conversion/Converter.swift) type is a structure defined in the runtime library and is used by both the client and server generated code to perform conversions between raw data and Swift types.++> Note: `Converter` is one of the SPI types, not considered part of the public API of the runtime library. However, because generated code relies on it, SPI stability needs to be considered when making changes to it and to the generator.++Most of the functionality of `Converter` is implemented as helper methods in extensions:+- [`Converter+Client.swift`](https://github.com/apple/swift-openapi-runtime/blob/main/Sources/OpenAPIRuntime/Conversion/Converter%2BClient.swift)+- [`Converter+Server.swift`](https://github.com/apple/swift-openapi-runtime/blob/main/Sources/OpenAPIRuntime/Conversion/Converter%2BServer.swift)+- [`Converter+Common.swift`](https://github.com/apple/swift-openapi-runtime/blob/main/Sources/OpenAPIRuntime/Conversion/Converter%2BCommon.swift)++Some helper methods can be reused between client and server code, such as headers, but most can't. It's important that we only generalize (move helper methods into common extensions) if the client and server variants would have been exact copies. However, if there are differences, prefer to keep them separate and optimize each variant (for client or server) separately.++### Generated code and generics interaction++As outlined in <doc:Project-scope-and-goals>, we aim to minimize the complexity of the generator and rely on the Swift compiler to help ensure that if generated code compiles, it's likely to work correctly.++To that end, if the input OpenAPI document contains an input that Swift OpenAPI Generator doesn't support, our first preference is to catch it in the generator and emit a descriptive diagnostic. However, there are cases where that is prohibitively complex, and we let the Swift compiler ensure that, for example, an array of strings cannot be used as a path parameter. In this example case, the generator emits code with the path parameter being of Swift type `[String]`, but since there doesn't exist a converter method for it, it will fail to build. This is considered expected behavior.++In the case of the converter, it contains helper methods for all the supported combinations of an HTTP location, a "content type family" and a Swift type.++First, a _schema location_ refers to one of the several places where schemas can be used in OpenAPI documents. For example:+- request path parameters+- request headers+- response bodies+- and more++Second, a _content type family_ can be one of:+- `structured`+    - example: `application/json`+    - uses the type's `Codable` implementation+- `text`+    - example: `text/plain`+    - uses the type's `LosslessStringConvertible` implementation, except for `Foundation.Date`, which uses a system date formatter+- `raw`+    - example: `application/octet-stream`+    - doesn't transform the raw data, just passes it through++The content type family is derived from the `content` map in the OpenAPI document, if provided. If none is provided, such as in case of parameters, `text` is used.++And third, a Swift type is calculated from the JSON schema provided in the OpenAPI document.++For example, a `string` schema is generated as `Swift.String`, an `object` schema is generated as a Swift structure, and an array schema is generated as a `Swift.Array` generic over the element type.++Together, the schema location, the content type family, and the Swift type is enough to unambiguously decide which helper method on the converter should be used.++For example, to use the converter to get a required response header of type `Foundation.Date` using the `text` content type family, look for a method (exact spelling is subject to change) that looks like:++```swift+func headerFieldGetTextRequired( // <<< 1.+    in headerFields: [HeaderField],+    name: String,+    as type: Date.Type // <<< 2.+) throws -> Date+```++In `1.`, notice that the method name contains which schema location, content type family, and optionality; while in `2.` it contains the Swift type.++### Helper method variants++In the nested list below, each leaf is one helper method.++"string-convertible" refers to types that conform to `LosslessStringConvertible` (but not `Foundation.Date`, which is handled separately).+++#### Required by client code++- request+   - set request path [client-only]+       - text+           - string-convertible+               - optional/required+           - date+               - optional/required+   - set request query [client-only]+       - text+           - string-convertible+               - optional/required+           - array of string-convertibles+               - optional/required+           - date+               - optional/required+           - array of dates+               - optional/required+   - set request headers [common]+       - text+           - string-convertible+               - optional/required+           - array of string-convertibles+               - optional/required+           - date+               - optional/required+           - array of dates+               - optional/required+       - structured+           - codable+               - optional/required

One more thought: if we do want to reuse the same method with a parameter, maybe the methods should have the word "structured" in them, so that we can later go from:

getParamStructured<T: Codable>(...) -> T

to

getParamStructured<T: Codable>(format: .json, ...) -> T
getParamStructured<T: Codable>(format: .xml, ...) -> T

So the full content type family would be:

  • JSON
  • XML
  • text
  • raw

But JSON and XML would share the helper methods. Does that make sense?

czechboy0

comment created time in an hour

startedapple/homebrew-apple

started time in an hour

PullRequestReviewEvent

push eventapple/llvm-project

Marco Elver

commit sha 33388d8c0b676009bcb4802d5db82865157cb41e

Revert "[compiler-rt] Allow 3 simultaneous interceptors on Linux" This reverts commit 57882fe76e1826593cd0e53f73484b184c5007c4. This reverts commit 74b0ac571b5facee3c8038d21ed71d7a29ee1098. Breaks various build bots.

view details

push time in an hour

PullRequestReviewEvent

startedapple/homebrew-apple

started time in an hour

startedapple/homebrew-apple

started time in an hour

Pull request review commentapple/swift-openapi-generator

[Docs] Document the Converter type and all the cases it needs to support

+# Converting between data and Swift types++Learn about the type responsible for convertering between raw data and Swift types.++## Overview++The [`Converter`](https://github.com/apple/swift-openapi-runtime/blob/main/Sources/OpenAPIRuntime/Conversion/Converter.swift) type is a structure defined in the runtime library and is used by both the client and server generated code to perform conversions between raw data and Swift types.++> Note: `Converter` is one of the SPI types, not considered part of the public API of the runtime library. However, because generated code relies on it, SPI stability needs to be considered when making changes to it and to the generator.++Most of the functionality of `Converter` is implemented as helper methods in extensions:+- [`Converter+Client.swift`](https://github.com/apple/swift-openapi-runtime/blob/main/Sources/OpenAPIRuntime/Conversion/Converter%2BClient.swift)+- [`Converter+Server.swift`](https://github.com/apple/swift-openapi-runtime/blob/main/Sources/OpenAPIRuntime/Conversion/Converter%2BServer.swift)+- [`Converter+Common.swift`](https://github.com/apple/swift-openapi-runtime/blob/main/Sources/OpenAPIRuntime/Conversion/Converter%2BCommon.swift)++Some helper methods can be reused between client and server code, such as headers, but most can't. It's important that we only generalize (move helper methods into common extensions) if the client and server variants would have been exact copies. However, if there are differences, prefer to keep them separate and optimize each variant (for client or server) separately.++### Generated code and generics interaction++As outlined in <doc:Project-scope-and-goals>, we aim to minimize the complexity of the generator and rely on the Swift compiler to help ensure that if generated code compiles, it's likely to work correctly.++To that end, if the input OpenAPI document contains an input that Swift OpenAPI Generator doesn't support, our first preference is to catch it in the generator and emit a descriptive diagnostic. However, there are cases where that is prohibitively complex, and we let the Swift compiler ensure that, for example, an array of strings cannot be used as a path parameter. In this example case, the generator emits code with the path parameter being of Swift type `[String]`, but since there doesn't exist a converter method for it, it will fail to build. This is considered expected behavior.++In the case of the converter, it contains helper methods for all the supported combinations of an HTTP location, a "content type family" and a Swift type.++First, a _schema location_ refers to one of the several places where schemas can be used in OpenAPI documents. For example:+- request path parameters+- request headers+- response bodies+- and more++Second, a _content type family_ can be one of:+- `structured`+    - example: `application/json`+    - uses the type's `Codable` implementation+- `text`+    - example: `text/plain`+    - uses the type's `LosslessStringConvertible` implementation, except for `Foundation.Date`, which uses a system date formatter+- `raw`+    - example: `application/octet-stream`+    - doesn't transform the raw data, just passes it through++The content type family is derived from the `content` map in the OpenAPI document, if provided. If none is provided, such as in case of parameters, `text` is used.++And third, a Swift type is calculated from the JSON schema provided in the OpenAPI document.++For example, a `string` schema is generated as `Swift.String`, an `object` schema is generated as a Swift structure, and an array schema is generated as a `Swift.Array` generic over the element type.++Together, the schema location, the content type family, and the Swift type is enough to unambiguously decide which helper method on the converter should be used.++For example, to use the converter to get a required response header of type `Foundation.Date` using the `text` content type family, look for a method (exact spelling is subject to change) that looks like:++```swift+func headerFieldGetTextRequired( // <<< 1.+    in headerFields: [HeaderField],+    name: String,+    as type: Date.Type // <<< 2.+) throws -> Date+```++In `1.`, notice that the method name contains which schema location, content type family, and optionality; while in `2.` it contains the Swift type.++### Helper method variants++In the nested list below, each leaf is one helper method.++"string-convertible" refers to types that conform to `LosslessStringConvertible` (but not `Foundation.Date`, which is handled separately).+++#### Required by client code++- request+   - set request path [client-only]+       - text+           - string-convertible+               - optional/required+           - date+               - optional/required+   - set request query [client-only]+       - text+           - string-convertible+               - optional/required+           - array of string-convertibles+               - optional/required+           - date+               - optional/required+           - array of dates+               - optional/required+   - set request headers [common]+       - text+           - string-convertible+               - optional/required+           - array of string-convertibles+               - optional/required+           - date+               - optional/required+           - array of dates+               - optional/required+       - structured+           - codable+               - optional/required

Not exactly the content type, but a "content type family" (happy to hear suggestions about a better name), described here: https://github.com/apple/swift-openapi-generator/pull/50/files#diff-aa92e58fb5a311512cfcd285827a4aa2e6634cae7fdfe0090bd2cfc7b0986140R32-R41

Content type family being one of (these are the new names proposed in this doc):

  • structured
  • text
  • raw

But you bring up a good point - even if we support XML, it'll rely on the Codable implementation of the type itself, but we still need to tell which encoder to use (JSON or XML), so let me amend the proposed "content type family" to be:

  • ~structured~ JSON
  • text
  • raw

With the idea that if/when we support XML, it'd be added as a 4th case here, and that might become an extra parameter, as all the cases where we support JSON we'll also support XML (so we won't need to double all the JSON-related methods, only add a new parameter, with JSON as fallback for backwards compat).

How does that sound, @simonjbeaumont?

czechboy0

comment created time in an hour

PullRequestReviewEvent
more