profile
viewpoint
Matt Karl bigtimebuddy Matt Karl, LLC Massachusetts https://mattkarl.com Tools Architect, Open Source Developer -- @ Netflix, Co-owner of PixiJS

bigtimebuddy/pixi-svg 105

SVG to Graphics DisplayObject for pixi.js

bigtimebuddy/pixi-graphics-format 5

PixiJS Graphics file format and Loader middleware

bigtimebuddy/create-pixi3d-app 1

Boilerplate project using Pixi3D, TypeScript and Webpack

bigtimebuddy/gradient-tool 1

Simple tool for generating gradients

bigtimebuddy/pixi-color-effects 1

A various color Matrix filters and Presets for pixi.js

AbigailNoble/abigailnoble.github.io 0

My personal website

pull request commentpixijs/pixijs

Fix passive interaction

Backport welcome

Zyie

comment created time in a day

pull request commentpixijs/pixijs

Change element to canvas

Nice!

Zyie

comment created time in a day

PullRequestReviewEvent

pull request commentpixijs/pixijs

v8 Pixel Rounding

I'm not sure the intention with roundPixels is to also give Text an aliased look, it's only to avoid rendering elements on sub-pixels. I think the Text thing is a cool feature, but is something different.

GoodBoyDigital

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentpixijs/pixijs

Fix: detectAvif/Webp not working in Worker

+export async function testImageFormat(imageData: string): Promise<boolean>+{+    try+    {+        // Some browsers currently do not support createImageBitmap with Blob, so new Image() is preferred when exist.+        // See https://caniuse.com/createimagebitmap for more information.++        if ('Image' in globalThis)+        {+            return await new Promise<boolean>((resolve) =>

We don't need the await here. I also think you can just put the try/catch around the createImageBitmap call.

            return new Promise<boolean>((resolve) =>
SuperSodaSea

comment created time in 4 days

PullRequestReviewEvent

issue commentpixijs/pixijs

Bug: why is there not exist function "getChildByName" in my Container

This can happen if you have multiple versions of pixi installed as a result of peer dependencies between plugins (check your package-lock.json for multiple @pixi/* versions). Please reference this https://github.com/pixijs/pixijs/wiki/Upgrading-PixiJS if are still having issues, please open a new issue with a reproduction.

shifangwang11

comment created time in 5 days

issue commentpixijs/pixijs

7.3.1 - Default condition should be last one

How are you getting this error? Can you please provide more information.

davidye

comment created time in 8 days

push eventpixijs/pixijs.com

Matt Karl

commit sha 6b3b7186790b7d006af6ee63bd39be88a5f07396

Add branding page

view details

push time in 8 days

release pixijs/pixijs

v7.3.1

released time in 8 days

push eventpixijs/pixijs

Zyie

commit sha 189f4abc7a230049b4688b817335756cc820c388

Fix: Use forked version of colord (#9686)

view details

Zyie

commit sha 650965947b95899cc04bc5ab848f7cb368b9e15d

Fix issue with loading asset without an alias (#9636)

view details

dev7355608

commit sha 7603e70adadfc16ec50d738f27c5de12d6ac7096

Fix: Round Sprite vertices in calculateTrimmedVertices if roundPixels (#9643)

view details

Matt Karl

commit sha b6299818cef9349620ca47d113a13042ed711a3d

v7.3.1

view details

push time in 8 days

created tagpixijs/pixijs

tagv7.3.1

The HTML5 Creation Engine: Create beautiful digital content with the fastest, most flexible 2D WebGL renderer.

created time in 8 days

push eventpixijs/pixijs

Matt Karl

commit sha b6299818cef9349620ca47d113a13042ed711a3d

v7.3.1

view details

push time in 8 days

pull request commentpixijs/pixijs

Fix: Round `Sprite` vertices in `calculateTrimmedVertices` if `roundPixels`

Thank you @dev7355608

dev7355608

comment created time in 8 days

delete branch pixijs/pixijs

delete branch : fix/spriteTrimmedRoundPixels

delete time in 8 days

push eventpixijs/pixijs

dev7355608

commit sha 7603e70adadfc16ec50d738f27c5de12d6ac7096

Fix: Round Sprite vertices in calculateTrimmedVertices if roundPixels (#9643)

view details

push time in 8 days

PR merged pixijs/pixijs

Fix: Round `Sprite` vertices in `calculateTrimmedVertices` if `roundPixels` ✅ Ready To Merge 💞 Migrate to v8

Rounding of vertices is missing in Sprite.calculateTrimmedVertices.

+11 -0

3 comments

1 changed file

dev7355608

pr closed time in 8 days

PR merged pixijs/pixijs

Reviewers
fix issue with loading asset without an alias ✅ Ready To Merge

Fixes #9633 and also fixes the use case where src can also be an object containing more src's

+152 -24

4 comments

12 changed files

Zyie

pr closed time in 8 days

issue closedpixijs/pixijs

Bug: loadParser option in Assets.load doesn't work without specifying alias

Current Behavior

loadParser option in Assets.load doesn't work without specifying alias.

PIXI.Assets.load({
    src: 'https://www.pixiplayground.com/',
    loadParser: 'loadTxt',
}).then(data => {
    console.log(typeof(data));
    console.log(data);
});

pixi.js 7.3.0-rc.2 Output:

object
null

Expected Behavior

Expected Output:

string
<!DOCTYPE html>
<html lang="en-US">
    <head>
        ...

Steps to Reproduce

See above.

Environment

Possible Solution

If we add alias to the options, the Assets.load can work properly.

// This works
PIXI.Assets.load({
    src: 'https://www.pixiplayground.com/',
    alias: '...',
    loadParser: 'loadTxt',
}).then(...)

Seems that the problem comes from here:

https://github.com/pixijs/pixijs/blob/f7e16da2b076f146f8954c708455112d2a2cc304/packages/assets/src/resolver/Resolver.ts#L496

The alias and name are both undefined, so aliasesToUse become [undefined].

https://github.com/pixijs/pixijs/blob/f7e16da2b076f146f8954c708455112d2a2cc304/packages/assets/src/resolver/Resolver.ts#L550-L553

... And finally resolvedAssets is written into this._assetMap[undefined], causing the issue.


A quick fix is:

- const aliasesToUse = convertToList<string>(alias || name);
+ const aliasesToUse = convertToList<string>(alias || name || src as string);

But this only works when src is a string.

Additional Information

No response

closed time in 8 days

SuperSodaSea

push eventpixijs/pixijs

Zyie

commit sha 650965947b95899cc04bc5ab848f7cb368b9e15d

Fix issue with loading asset without an alias (#9636)

view details

push time in 8 days

delete branch pixijs/pixijs

delete branch : fix/asset-load

delete time in 8 days

pull request commentpixijs/pixijs

use forked version of colord

Could you make an issue with the original project to see if we can get those imports fixed?

Zyie

comment created time in 8 days

delete branch pixijs/pixijs

delete branch : fix/colord

delete time in 8 days

issue closedpixijs/pixijs

Bug: Documentation examples fail to render: /src/index.js: r is not a function (1:0)

Current Behavior

When navigating to any of the examples or the playground on the pixi website I receive this error on both dev and v7.3.x:

Screen Shot 2023-09-20 at 5 32 07 PM

This error occurs on both Firefox and Chrome.

Expected Behavior

Examples and playground should render pixijs code.

Steps to Reproduce

Navigate to the playground or any of the examples and make sure version v7.3.x (default) or dev are selected. Canvas will not render but instead show an error with a cryptic message:

/src/index.js: r is not a function (1:0)

> 1 | import * as PIXI from 'pixi.js';
      ^
  2 | 
  3 | const app = new PIXI.Application({ background: '#1099bb', resizeTo: window });
  4 | 

Environment

  • pixi.js version: v7.3.x
  • Browser & Version: Version 116.0.5845.96 (Official Build) (arm64) and Firefox Version 117
  • OS & Version: MacOS
  • Running Example: https://pixijs.com/playground

Possible Solution

This is my first time using pixijs so not sure!

Additional Information

No response

closed time in 8 days

treygilliland

push eventpixijs/pixijs

Zyie

commit sha 189f4abc7a230049b4688b817335756cc820c388

Fix: Use forked version of colord (#9686)

view details

push time in 8 days

PR merged pixijs/pixijs

use forked version of colord 🔥 High Priority ✅ Ready To Merge

Added our forked version of colord to fix the issues with CSB and it importing the incorrect files

+19 -20

1 comment

6 changed files

Zyie

pr closed time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent
more