profile
viewpoint
Brian Prodoehl bprodoehl Connectify Philadelphia, PA

bprodoehl/docker-log-collector 32

A Docker container with fluentd

bprodoehl/docker-piwik 12

A Docker container running the latest release of Piwik.

bprodoehl/docker-piwik-mariadb 8

A Dockerfile for an all-in-one Piwik + MariaDB container.

bprodoehl/docker-android-dev 5

Android development environment for Ubuntu trusty tahr (14.04 LTS)

bprodoehl/docker-nginx-php-fail2ban 4

A Docker container running nginx with PHP and Fail2ban

bprodoehl/docker-chromium-dev 3

A Docker container with many of the dependencies required for building Chromium and WebRTC

bprodoehl/docker-dns-server 2

A simple DNS server in a Docker container, intended to easily take hostname entries

bprodoehl/docker-s3-backup 2

A Docker container to act as a Jenkins slave, capable of backing up volumes and MySQL databases to Amazon S3.

PullRequestReviewEvent
MemberEvent

PR merged Connectify/openwrt-netem

netem-control procd init

Updated netem-control to make use of procd init instead of ucitrack which is now legacy.

Packages compiled and tested with OpenWrt r22.03.2

+118 -102

1 comment

11 changed files

pbeyl

pr closed time in 2 months

push eventConnectify/openwrt-netem

Paul Beyleveld

commit sha 69460a29d8dc76a3883eca608873e0754d58013e

Updated netem-control to make use of procd init instead of ucitrack which is now legacy

view details

pbeyl

commit sha 062381ed5ec37ea27aa9b8d5783ba8de7b820daf

Update README.md

view details

Brian Prodoehl

commit sha 68afb8a407eaa5159aba8cd09e1c309822dab3ff

Merge pull request #2 from pbeyl/procd-init netem-control procd init

view details

push time in 2 months

PullRequestReviewEvent

issue openedConnectify/openwrt-netem

Add support for netem slot parameter

The slot parameter in netem can be used to better simulate bursty MACs, like Wi-Fi and 4G. This package should be enhanced to support that.

https://man7.org/linux/man-pages/man8/tc-netem.8.html

created time in 2 months

Pull request review commentConnectify/openwrt-netem

netem-control procd init

 openwrt-netem ============= -OpenWrt packages for easy WAN emulation.\ No newline at end of file+OpenWrt packages for easy WAN emulation.++### Compiling the packages require the followinfg steps:

would you mind fixing this typo? followinfg -> following

pbeyl

comment created time in 2 months

Pull request review commentConnectify/openwrt-netem

netem-control procd init

 function setRules (operation)     local qdisc_parent = 0     local errors = 0 +    if ( operation == "del") then+        --remove all rules associated to previously added interfaces+        for k,v in ipairs(intfcfg) do+            tc_str = "tc qdisc del dev "..v.." root"+            exec(tc_str)+        end+        table.remove(intfcfg)+        return+    end+     x:foreach("netem", "interface",     function (section)+         iface = x:get("netem", section[".name"], "ifname")         if iface == nil then             return         end+         enabled = x:get("netem", section[".name"], "enabled")         if enabled == "1" then             qdisc_parent = qdisc_parent + 1+            --keep track of all interfaces where we are adding rules+            table.insert(intfcfg, iface) -            if (operation == "add" or operation == "del") then-                tc_str = "tc qdisc del dev "..iface.." root"-                exec(tc_str)+            if (operation == "add") then+                --tc_str = "tc qdisc del dev "..iface.." root"

I think commenting out this qdisc del dev should be ok, but I'm pretty sure we had it delete and then replace because of issues once upon a time with trying to change a qdisc.

pbeyl

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentConnectify/openwrt-netem

netem-control procd init

This looks great, thanks! I'll take a more thorough look at it soon.

pbeyl

comment created time in 2 months

more