dtolnay ( David Tolnay )

`quote!` and `quote_spanned!` macro should take `&mut TokenStream`

Hey! dtolnay, Thanks for your great work! ❤️

I think quote! and quote_spanned! macro should take &mut TokenStream instead of creating new one.

Instead of this:

let import = items.iter().map(|item| quote_spanned!(item.span()=> use #item));
quote! { 
    #(#import)* 
    // ...
}

I think it should look something like this:

// `to_tokens_fn` accept closure and return a struct that implement `ToTokens`

let import = to_tokens_fn(|tokens| { 
    for item in items {
        quote_spanned!(tokens, item.span()=> use #item);
    }
});

impl ToTokens for <Struct> {
    fn to_tokens(&self, tokens: &mut proc_macro2::TokenStream) {
        quote!(tokens, { 
            #import
            // ...
        })
    }
}

This approach should be more performance, Because it avoid cloning.

Sorry if this is duplicate.

closed time in 2 hours

arafatrahman862

issue commentdtolnay/quote

`quote!` and `quote_spanned!` macro should take `&mut TokenStream`

I would prefer not to support this in this crate.

arafatrahman862

comment created time in 2 hours

create barnchdtolnay-contrib/reindeer

branch : git

created branch time in 20 hours

delete branch dtolnay-contrib/reindeer

delete branch : master

delete time in 20 hours

issue openedfacebookincubator/reindeer

Crates in lockfile are incompatible with current nightly Rust

The readme's recommended installation instruction of cargo install --locked --git https://github.com/facebookincubator/reindeer fails on nightly:

error: to use a constant of type `TypeId` in a pattern, `TypeId` must be annotated with `#[derive(PartialEq, Eq)]`
  --> value-bag-1.0.0-alpha.9/src/internal/cast/primitive.rs:43:33
   |
43 |   ...                           $const_ident => |v| Some(Internal::from(unsafe { &*(*...
   |                                 ^^^^^^^^^^^^
...
71 | / ...   to_internal![
72 | | ...       usize: (USIZE, OPTION_USIZE),
73 | | ...       u8: (U8, OPTION_U8),
74 | | ...       u16: (U16, OPTION_U16),
...  |
96 | | ...       String: (STRING, OPTION_STRING),
97 | | ...   ];
   | |_______- in this macro invocation
   |
   = note: the traits must be derived, manual `impl`s are not sufficient
   = note: see https://doc.rust-lang.org/stable/std/marker/trait.StructuralEq.html for details
   = note: this error originates in the macro `to_internal` (in Nightly builds, run with -Z macro-backtrace for more info)

error: to use a constant of type `TypeId` in a pattern, `TypeId` must be annotated with `#[derive(PartialEq, Eq)]`
  --> value-bag-1.0.0-alpha.9/src/internal/cast/primitive.rs:46:33
   |
46 |                                   $option_ident => |v| Some({
   |                                   ^^^^^^^^^^^^^
...
71 | /         to_internal![
72 | |             usize: (USIZE, OPTION_USIZE),
73 | |             u8: (U8, OPTION_U8),
74 | |             u16: (U16, OPTION_U16),
...  |
96 | |             String: (STRING, OPTION_STRING),
97 | |         ];
   | |_________- in this macro invocation
   |
   = note: the traits must be derived, manual `impl`s are not sufficient
   = note: see https://doc.rust-lang.org/stable/std/marker/trait.StructuralEq.html for details
   = note: this error originates in the macro `to_internal` (in Nightly builds, run with -Z macro-backtrace for more info)

error: to use a constant of type `TypeId` in a pattern, `TypeId` must be annotated with `#[derive(PartialEq, Eq)]`
  --> value-bag-1.0.0-alpha.9/src/internal/cast/primitive.rs:55:29
   |
55 |   ...                       STR => |v| Some(Internal::from(unsafe { &**(v as *const &...
   |                             ^^^
...
71 | / ...   to_internal![
72 | | ...       usize: (USIZE, OPTION_USIZE),
73 | | ...       u8: (U8, OPTION_U8),
74 | | ...       u16: (U16, OPTION_U16),
...  |
96 | | ...       String: (STRING, OPTION_STRING),
97 | | ...   ];
   | |_______- in this macro invocation
   |
   = note: the traits must be derived, manual `impl`s are not sufficient
   = note: see https://doc.rust-lang.org/stable/std/marker/trait.StructuralEq.html for details
   = note: this error originates in the macro `to_internal` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `value-bag` (lib) due to 3 previous errors

Without --locked, it installs successfully using a newer version of value-bag.

created time in 21 hours

create barnchdtolnay-contrib/cxx

branch : serde

created branch time in a day

push eventdtolnay-contrib/buck2-prelude

Michael Shtutman

commit sha 3e4d218ced25406bf51041a685fe30d870f88dca

Fix maven urls Summary: buck2 is not able to handle some of `mvn:XXX` target types. Buck2 migration is mandatory and due by June. We're buckifying an old legacy maven service D46071993 which is to be deprecated soon and went for using maven artifacts in buck until we delete the whole service by the EOY. ``` * fbcode/buck2/prelude/remote_file.bzl:50, in <module> url = _from_mvn_url(url) * fbcode/buck2/prelude/remote_file.bzl:27, in _from_mvn_url fail("Unsupported mvn URL scheme: " + url + " (" + str(count) + ")") error: fail: Unsupported mvn URL scheme: mvn:io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.58.Final (5) --> fbcode/buck2/prelude/remote_file.bzl:27:9 | 27 | fail("Unsupported mvn URL scheme: " + url + " (" + str(count) + ")") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ``` Reviewed By: andrewjcg Differential Revision: D45992990 fbshipit-source-id: 0542f77255f1cd155b37f50a41f18d027e9af9e3