profile
viewpoint
The kraken.js team krakenjs http://www.krakenjs.com The kraken.js team at PayPal

krakenjs/beaver-logger 245

Client-side logging w/ super powers

krakenjs/cross-domain-utils 132

Cross Domain utilities

krakenjs/adaro 127

A Dust.js view renderer for express

krakenjs/confit 61

Environment-aware configuration.

krakenjs/caller 45

A node module for enabling a module to determine its caller.

krakenjs/cross-domain-safe-weakmap 33

Cross-domain safe WeakMap shim

krakenjs/angular-remove-di-loaders 17

Webpack loaders to remove Angular DI (Dependency Injection)

krakenjs/belter 16

Miscellaneous browser utilities

krakenjs/bundalo 10

Manage localized sets of content files (be they property/json/etc) which may require rendering with data models

krakenjs/beaver-logger-ios 2

Beaver Logger client for iOS

startedkrakenjs/zoid

started time in 21 hours

startedkrakenjs/post-robot

started time in 2 days

issue commentkrakenjs/zoid

Zoid breaks OneLogin: window.open might be called without arguments

Hi everyone,

We even had to remove zoid from our project because our partners code triggered this error. I assume this can be an issue not only for us according to above posts.

Our partners seems to use Auth0 popup where window.open has been called without a URL..

Thanks

theKashey

comment created time in 2 days

issue commentkrakenjs/zoid

Zoid breaks OneLogin: window.open might be called without arguments

Hello,

I have the same problem with oidc-client-ts which open a popup with window.open and undefined url: TypeError: Cannot read properties of undefined (reading ‘match’”)).

https://github.com/authts/oidc-client-ts/blob/6937ed3128d02a0dfa5bc81aadec2d74cbed650c/src/navigators/PopupWindow.ts#L34

It is possible to add a check on window.open to test if url is defined or an url is mandatory for zoid use ? From the documentation, window.open can be called without an url

theKashey

comment created time in 2 days

created tagkrakenjs/passport-saml-encrypted

tagv0.1.12

A strategy for Passport authentication that supports encrypted SAML responses

created time in 3 days

push eventkrakenjs/passport-saml-encrypted

Shaun Warman

commit sha 56eabc6f0eee6ee17c5c9b62003a486b249fa0fc

0.1.12

view details

push time in 3 days

startedkrakenjs/jsx-pragmatic

started time in 4 days

push eventkrakenjs/passport-saml-encrypted

Shaun Warman

commit sha 703092071f72ed58d18a44f8bef5d9170aa951a1

fix: add error handling when validating saml response

view details

Shaun Warman

commit sha 7d1ef14234a71e5a61a001e39f7b442fc412c174

Merge pull request #27 from krakenjs/fix-error-handling fix: add error handling when validating saml response

view details

push time in 4 days

PR merged krakenjs/passport-saml-encrypted

Reviewers
fix: add error handling when validating saml response
  • Add missing error handling when validating the SAML response. We noticed this when saml assertion was not encrypted which would lead to a hanging request.
+17 -1

0 comment

1 changed file

shaunwarman

pr closed time in 4 days

fork payk-12/zoid

Cross domain components

fork in 4 days

startedkrakenjs/zoid

started time in 5 days

issue commentkrakenjs/zoid

Minimalist example shows spinning window.

Of course, it was my fault because the parent and child component tags didn't match perfectly!

<!DOCTYPE html> <html> <head> <title>Parent</title> <script src="https://cdnjs.cloudflare.com/ajax/libs/zoid/9.0.44/zoid.min.js"></script> <script> // Create the Zoid component var MyComponent = zoid.create({ tag: 'my-component', url: '/child3' // Make sure this URL points to your child.html }); </script> </head> <body> <h1>Parent Page</h1> <!-- Container to render the Zoid component --> <div id="my-container"></div>

<script>
    // Render the Zoid component
    MyComponent().render('#my-container');
</script>

</body> </html>

CHILD: <!DOCTYPE html> <html> <head> <title>Child</title> <script src="https://cdnjs.cloudflare.com/ajax/libs/zoid/9.0.44/zoid.min.js"></script> <script> // Create the Zoid component on the child as well zoid.create({ tag: 'my-component' }); </script> </head> <body> <h1>Child Page</h1> </body> </html>

engdevlab

comment created time in 6 days

issue closedkrakenjs/zoid

Minimalist example shows spinning window.

I've tried a few minimalist examples but the parent never renders the iframe. In this example I see my "Parent Page" html rendered, I see the iframe box, though the pre-rendering spinner just spins and the page is never shown. I can see the 200 response from /helloworld. No console errors. No network errors. Full refresh. Not sure where to look. Tried firefox, chrome, etc. I couldn't even see a sample js fiddler to try as a base.

Maybe these cnds are old? <!DOCTYPE html> <html lang="en"> <head> <meta charset="UTF-8"> <script src="https://cdnjs.cloudflare.com/ajax/libs/zoid/9.0.63/zoid.min.js"></script> <title>Parent Page</title> <script> var MyBasicComponent = zoid.create({ tag: 'my-basic-component', url: 'http://127.0.0.1:5001/helloworld' }); </script> </head> <body> <main> Parent Page <div id="parent-container"></div> </main> <script> MyBasicComponent().render('#parent-container'); </script> </body> </html>

closed time in 6 days

engdevlab

issue commentkrakenjs/zoid

Minimalist example shows spinning window.

It just seems to stick at zoid-invisible If I put the iframe to zoid-visible manually I can see the page rendered. I suppose there's a create parameter I'm not setting?

engdevlab

comment created time in 6 days

issue openedkrakenjs/zoid

Minimalist example shows spinning window.

I've tried a few minimalist examples but the parent never renders the iframe. In this example I see my "Parent Page" html rendered, I see the iframe box, though the pre-rendering spinner just spins and the page is never shown. I can see the 200 response from /helloworld. No console errors. No network errors. Full refresh. Not sure where to look. Tried firefox, chrome, etc. I couldn't even see a sample js fiddler to try as a base.

Maybe these cnds are old?

<!DOCTYPE html> <html lang="en"> <head> <meta charset="UTF-8"> <script src="https://cdnjs.cloudflare.com/ajax/libs/zoid/9.0.63/zoid.min.js"></script> <title>Parent Page</title> <script> var MyBasicComponent = zoid.create({ tag: 'my-basic-component', url: 'http://127.0.0.1:5001/helloworld' }); </script> </head> <body> <main> <h1>Parent Page</h1> <div id="parent-container"></div> </main> <script> MyBasicComponent().render('#parent-container'); </script> </body> </html

created time in 6 days

startedkrakenjs/zoid

started time in 8 days

startedkrakenjs/kraken-js

started time in 9 days

startedkrakenjs/jsx-pragmatic

started time in 9 days

startedkrakenjs/post-robot

started time in 10 days

startedkrakenjs/lusca

started time in 10 days

startedkrakenjs/kraken-js

started time in 11 days

Pull request review commentkrakenjs/passport-saml-encrypted

fix: add error handling when validating saml response

 Strategy.prototype.authenticate = function (req, options) {       self._verify(profile, verified);     });     }catch(err){-      // Error Handling+      // This could happen for various reasons, but often means +      // the saml response / assertion is not encrypted+      return self.error(err);

We can try releasing a beta or canary version of this package and link that in for testing locally. We'll need to pair with SSO on using an unencrypted response.

shaunwarman

comment created time in 11 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentkrakenjs/passport-saml-encrypted

fix: add error handling when validating saml response

 Strategy.prototype.authenticate = function (req, options) {       self._verify(profile, verified);     });     }catch(err){-      // Error Handling+      // This could happen for various reasons, but often means +      // the saml response / assertion is not encrypted+      return self.error(err);

any way to test this?

I hope we are not silencing the error later in the code flow. does it make sense to add console.error (if we are not sure if it's throwing error or not)

shaunwarman

comment created time in 11 days

PR opened krakenjs/passport-saml-encrypted

fix: add error handling when validating saml response
  • Add missing error handling when validating the SAML response. We noticed this when saml assertion was not encrypted which would lead to a hanging request.
+17 -1

0 comment

1 changed file

pr created time in 11 days

create barnchkrakenjs/passport-saml-encrypted

branch : fix-error-handling

created branch time in 11 days

fork trasherdk/kraken-js

An express-based Node.js web application bootstrapping module.

fork in 12 days

startedkrakenjs/kraken-js

started time in 12 days

more