lukastaegert ( Lukas Taegert-Atkinson )

commit sha fbc25afcc2e494b562358479524a88ab8fe0f1bf

[v4.0] feat: implement hashing content in Rust (#5155)

push time in 6 hours

PR merged rollup/rollup

[v4.0] feat: implement hashing content in Rust

<!-- ⚡️ katchow! We ❤️ Pull Requests!

If you remove or skip this template, you'll make the 🐼 sad and the mighty god of Github will appear and pile-drive the close button from a great height while making animal noises.

Pull Request Requirements:

Please include tests to illustrate the problem this PR resolves.
Please lint your changes by running npm run lint before creating a PR.
Please update the documentation in /docs where necessary

Please place an x (no spaces - [x]) in all [ ] that apply. -->

This PR contains:

[ ] bugfix
[ ] feature
[x] refactor
[ ] documentation
[ ] other

Are tests included?

[x] yes (bugfixes and features will not be merged without tests)
[ ] no

Breaking Changes?

[x] yes (breaking changes will not be merged unless absolutely necessary)
[ ] no

List any relevant issue numbers: resolves #4803 <!-- If this PR resolves any issues, list them as

resolves #1234

where 1234 is the issue number. This will help us with house-keeping as Github will automatically add a note to those issues stating that a potential fix exists. Once the PR is merged, Github will automatically close those issues.

If an issue is only solved partially or is relevant in some other way, just list the number without "resolves". -->

Description

Currently we still have a sha256 hex encoding for the asset referenceId because a valid js variable cannot include - character. <!-- Please be thorough and clearly explain the problem being solved.

If this PR adds a feature, look for previous discussion on the feature by searching the issues first.
Is this PR related to an issue? -->

+504 -491

2 commit in rollup/rollup/tree/xiaopi-migrate-hex-to-base64url rollup/rollup/tree/release-4.0

3 comments

416 changed files

TrickyPi

pr closed time in 6 hours

PullRequestReviewEvent

push eventrollup/rollup

commit sha 4e92d60fa90cead39481e3703d26e5d812f43bd1

Deoptimize all parameters when losing track of a function (#5158)

commit sha a6448b99f725d457e35821b73a865b5c4d4c6a61

3.29.4

renovate[bot]

commit sha fac5f1c1c12dc0409ff090664e305586747dc2f7

chore(deps): lock file maintenance minor/patch updates (#5160) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit sha 4576ef3dfaf83415b319c851acd1a85b100e4ad1

[v4.0] Set minimum Node version to 18

commit sha 643272e0d11a28bd56491719b75f95147bb66ac7

[v4.0] Switch parser to SWC and introduce native/WASM code (#5073) * Add native compilation for local NodeJS * Link instead of copying for faster dev cycles for now * Parse AST * Convert first trivial AST to a buffer * Use SWC for parsing * Extend AST conversion * Make AST more similar * Fix line number issue by creating a new sourcemap (and thus compiler) for each run * Collect timings * Add code_length to struct * Refine parsing * Extend parsing * Extend AST: ImportDefaultSpecifier, LiteralBoolean, LiteralNull, ExportDefaultExpression * Extend AST: ImportNamespaceSpecifier, ExportAll * Extend AST: BinaryExpression, ArrayPattern, ObjectPattern, AssignmentPatternProperty, ArrayLiteral, ImportExpression * Extend AST: ConditionalExpression * Extend AST: FunctionDeclaration, ClassDeclaration, ClassBody, ReturnStatement * Extend AST: ObjectLiteral, KeyValueProperty * Extend AST: ShorthandProperty * Extend AST: GetterProperty, AssignmentExpression, NewExpression, FunctionExpression * Extend AST: ThrowStatement * Extend AST: ExportDefaultDeclaration * Extend AST: AssignmentPattern, AwaitExpression, BreakStatement Start sorting AST nodes * Extend AST: TryStatement, CatchClause, ChainExpression * Extend AST: ClassExpression, ContinueStatement, DebuggerStatement, DoWhileStatement, EmptyStatement * Extend AST: ExportNamedDeclaration, ForInStatement, ForOfStatement, ForStatement * Extend AST: IfStatement * Extend AST: Import attributes * Extend AST: Literal<RegExp>, Literal<BigInt> * Extend AST: LogicalExpression * Extend AST: MetaProperty * Extend AST: Various Property types * Extend AST: Progress on classes * Extend AST: MethodDefinition, PropertyDefinition, PrivateName, ThisExpression * Extend AST: StaticBlock, Super * Extend AST: RestElement, SequenceExpression, SwitchCase, SwitchStatement * Extend AST: TaggedTemplateExpression, TemplateElement, TemplateLiteral, UnaryExpression, UpdateExpression, YieldExpression * Extend AST: Properties in object patterns * Finishing Fixes * More fixes * Run cargo fmt * Handle directives * Minor fixes * Unicode support * Fix optional chain expressions * Adapt tests * Do not run acorn anymore * Update lockfile * Minor fixes * Move to rust folder * Separate Rust Node bindings to allow adding WASM bindings in another workspace * Make Napi build closer to how rs.napi works * Fix path issues * Disable browser build for now * Add native package directories * Refine runWithEcho * Try initial steps with Github flow * Trigger change * Temporarily add yarn lockfile until we figured out if we get it to work with npm * Use nightly toolchain * Use default locations for Napi files to make things easier * Adapt workflow * Skip regular tests for now * Attempt to fix broken workflows * Attempt to fix broken workflows * Attempt to fix broken workflows * Test MacOS/WIndows * Fix bootstrap build * Skip tests * Rename workflow * Add additional tests * Use zig differently * Try to fix musl build * Skip musl again for now * Add publish to workflow * 4.0.0-0 * Remove yarn lock again * Fix coverage job * Fix artefact handling * Revert "4.0.0-0" This reverts commit 734806f0ae9a4cfa63e996c2d9be099b2a4580bf. * 4.0.0-0 * Do not include default triples twice * Fix native npm packages * 4.0.0-1 * Add missing additional tests except browser tests * Try to fix publish and tests * 4.0.0-2 * Switch to faster utf-16 conversion * 4.0.0-3 * Fix positioning algorithm when manually searching the code * 4.0.0-4 * feat: Add WASM browser build (#5077) * feat: add wasm browser build * move wasm binding into a separate cargo workspace * use imports replacing * set the targetEnv option of wasm to browser in browser build * add the wasm build to build command * fix lint error and ci error * add more comments to silence the linter * big change * trigger change * run browser tests * trigger change * tweak wasm build on CI * Increase build timeout * Use shared string constants * Extract fixed strings into constants * Remove comment * Get rid of dbg! calls * Add lockfile hash to cargo cache * Use if let over match in some cases * Return the buffer of the syntax error in parse_ast * Initial annotation support * Put annotation types into string table * Remove invalid annotations * Support nested calls and new expressions * Improve tree-shaking for annotations * Adapt test * Properly handle line-breaks, commas etc. * Mark nested pure annotations as pure * Remove sourcemap comments * Handle function side effect annotatinos * Remove old comment-handling code * Increase timeout for browser tests * Only skip the tests that still fail * Run coverage again on CI * Get the buffer of pos and message from the Syntax error * Handle the lint errors from SWC * Reenable tests about parse errors and adjust some relevant code * Emit native.js to native.cjs * Add cjs extension for native importee when bundling for ESM * Change native importee with replace plugin and emit native.cjs in napi build * Silence the linter for importing native * Use node:path to resolve native binding files * Add Node WASM files to Native packages for StackBlitz and similar use cases * Unignore *.d.ts in the wasm dir * 4.0.0-5 * Fix copy-wasm-node.js * 4.0.0-6 * Remove .gitignore in wasm-node directory * 4.0.0-7 * Include .cjs files when publishing rollup to npm * 4.0.0-8 * Get readString function at runtime * eslint: ignore wasm-node and set node extensions of import/resolver * 4.0.0-9 * Change the required node to >=14.18.0 as before * 4.0.0-10 * Prepare to fix ESM build Still requires bug-fix on Rollup side for relative external dependencies outside the ouput directory * Update Rollup * Enable ESM tests * Re-enable another test * Remove CJS eslint configuration * Fix extension * Fix test * Fix entension for native import * Support for publishing a completely separate package @rollup/wasm-node * 4.0.0-11 * Fix publish for wasm node package * Add AST verification to function tests * Only use plugin arrays in form and function tests * Fix spans in function tests * Verify AST in form tests as well * Try to publish @rollup/browser and fix publish-wasm-node-package.js * 4.0.0-12 * Tweak publish scripts * Fix importing wasm file in browser * Parse code as unknown module type for greater compatibility * Remove acorn options * Tweak getReadStringFunction * Fix browser tests * 4.0.0-13 * Remove polyfills that are no longer needed in browser tests * Convert to new import attributes AST format * Rename assertions to attributes * Deprecate externalImportAssertions in favor of externalImportAttributes * Update SWC version * Remove max-call-stack test SWC is not capable of handling it and we cannot fix it * Improve coverage * re-enable repl-artefacts workflow * Fix test * Preload wasm file in docs * docs: add functions to get full path of url * Delete the build plugin handleImportMetaUrl * Make 'npm install github/branch' work * Verify there is a valid changelog entry before releasing * Create release notes and comments from CI Minor change to maybe trigger a CI run * Fix RegExp * 4.0.0-14 * Minor changes for a test PR (#5139) * Fix RegExp use * 4.0.0-15 * Do not rely on current branch to find the PR * 4.0.0-16 * Fix how to determine git commit range * 4.0.0-17 * Make sure we fetch all history on publish * 4.0.0-18 * Add proper permissions * 4.0.0-19 * Use Double quotation marks instead of Single quotation marks if concurrently scripts with flags * Remove "engines" from native packages * Update CONTRIBUTING.md --------- Co-authored-by: XiaoPi <530257315@qq.com>

commit sha 92864d48896dd09c0381d4b1cbef769a03c3f7d1

[v4.0] Set the default of skipSelf to true (#5142) * Set minimum Node version to 18 * Set the default of skipSelf to true * [v4.0] Switch parser to SWC and introduce native/WASM code (#5073) * Add native compilation for local NodeJS * Link instead of copying for faster dev cycles for now * Parse AST * Convert first trivial AST to a buffer * Use SWC for parsing * Extend AST conversion * Make AST more similar * Fix line number issue by creating a new sourcemap (and thus compiler) for each run * Collect timings * Add code_length to struct * Refine parsing * Extend parsing * Extend AST: ImportDefaultSpecifier, LiteralBoolean, LiteralNull, ExportDefaultExpression * Extend AST: ImportNamespaceSpecifier, ExportAll * Extend AST: BinaryExpression, ArrayPattern, ObjectPattern, AssignmentPatternProperty, ArrayLiteral, ImportExpression * Extend AST: ConditionalExpression * Extend AST: FunctionDeclaration, ClassDeclaration, ClassBody, ReturnStatement * Extend AST: ObjectLiteral, KeyValueProperty * Extend AST: ShorthandProperty * Extend AST: GetterProperty, AssignmentExpression, NewExpression, FunctionExpression * Extend AST: ThrowStatement * Extend AST: ExportDefaultDeclaration * Extend AST: AssignmentPattern, AwaitExpression, BreakStatement Start sorting AST nodes * Extend AST: TryStatement, CatchClause, ChainExpression * Extend AST: ClassExpression, ContinueStatement, DebuggerStatement, DoWhileStatement, EmptyStatement * Extend AST: ExportNamedDeclaration, ForInStatement, ForOfStatement, ForStatement * Extend AST: IfStatement * Extend AST: Import attributes * Extend AST: Literal<RegExp>, Literal<BigInt> * Extend AST: LogicalExpression * Extend AST: MetaProperty * Extend AST: Various Property types * Extend AST: Progress on classes * Extend AST: MethodDefinition, PropertyDefinition, PrivateName, ThisExpression * Extend AST: StaticBlock, Super * Extend AST: RestElement, SequenceExpression, SwitchCase, SwitchStatement * Extend AST: TaggedTemplateExpression, TemplateElement, TemplateLiteral, UnaryExpression, UpdateExpression, YieldExpression * Extend AST: Properties in object patterns * Finishing Fixes * More fixes * Run cargo fmt * Handle directives * Minor fixes * Unicode support * Fix optional chain expressions * Adapt tests * Do not run acorn anymore * Update lockfile * Minor fixes * Move to rust folder * Separate Rust Node bindings to allow adding WASM bindings in another workspace * Make Napi build closer to how rs.napi works * Fix path issues * Disable browser build for now * Add native package directories * Refine runWithEcho * Try initial steps with Github flow * Trigger change * Temporarily add yarn lockfile until we figured out if we get it to work with npm * Use nightly toolchain * Use default locations for Napi files to make things easier * Adapt workflow * Skip regular tests for now * Attempt to fix broken workflows * Attempt to fix broken workflows * Attempt to fix broken workflows * Test MacOS/WIndows * Fix bootstrap build * Skip tests * Rename workflow * Add additional tests * Use zig differently * Try to fix musl build * Skip musl again for now * Add publish to workflow * 4.0.0-0 * Remove yarn lock again * Fix coverage job * Fix artefact handling * Revert "4.0.0-0" This reverts commit 734806f0ae9a4cfa63e996c2d9be099b2a4580bf. * 4.0.0-0 * Do not include default triples twice * Fix native npm packages * 4.0.0-1 * Add missing additional tests except browser tests * Try to fix publish and tests * 4.0.0-2 * Switch to faster utf-16 conversion * 4.0.0-3 * Fix positioning algorithm when manually searching the code * 4.0.0-4 * feat: Add WASM browser build (#5077) * feat: add wasm browser build * move wasm binding into a separate cargo workspace * use imports replacing * set the targetEnv option of wasm to browser in browser build * add the wasm build to build command * fix lint error and ci error * add more comments to silence the linter * big change * trigger change * run browser tests * trigger change * tweak wasm build on CI * Increase build timeout * Use shared string constants * Extract fixed strings into constants * Remove comment * Get rid of dbg! calls * Add lockfile hash to cargo cache * Use if let over match in some cases * Return the buffer of the syntax error in parse_ast * Initial annotation support * Put annotation types into string table * Remove invalid annotations * Support nested calls and new expressions * Improve tree-shaking for annotations * Adapt test * Properly handle line-breaks, commas etc. * Mark nested pure annotations as pure * Remove sourcemap comments * Handle function side effect annotatinos * Remove old comment-handling code * Increase timeout for browser tests * Only skip the tests that still fail * Run coverage again on CI * Get the buffer of pos and message from the Syntax error * Handle the lint errors from SWC * Reenable tests about parse errors and adjust some relevant code * Emit native.js to native.cjs * Add cjs extension for native importee when bundling for ESM * Change native importee with replace plugin and emit native.cjs in napi build * Silence the linter for importing native * Use node:path to resolve native binding files * Add Node WASM files to Native packages for StackBlitz and similar use cases * Unignore *.d.ts in the wasm dir * 4.0.0-5 * Fix copy-wasm-node.js * 4.0.0-6 * Remove .gitignore in wasm-node directory * 4.0.0-7 * Include .cjs files when publishing rollup to npm * 4.0.0-8 * Get readString function at runtime * eslint: ignore wasm-node and set node extensions of import/resolver * 4.0.0-9 * Change the required node to >=14.18.0 as before * 4.0.0-10 * Prepare to fix ESM build Still requires bug-fix on Rollup side for relative external dependencies outside the ouput directory * Update Rollup * Enable ESM tests * Re-enable another test * Remove CJS eslint configuration * Fix extension * Fix test * Fix entension for native import * Support for publishing a completely separate package @rollup/wasm-node * 4.0.0-11 * Fix publish for wasm node package * Add AST verification to function tests * Only use plugin arrays in form and function tests * Fix spans in function tests * Verify AST in form tests as well * Try to publish @rollup/browser and fix publish-wasm-node-package.js * 4.0.0-12 * Tweak publish scripts * Fix importing wasm file in browser * Parse code as unknown module type for greater compatibility * Remove acorn options * Tweak getReadStringFunction * Fix browser tests * 4.0.0-13 * Remove polyfills that are no longer needed in browser tests * Convert to new import attributes AST format * Rename assertions to attributes * Deprecate externalImportAssertions in favor of externalImportAttributes * Update SWC version * Remove max-call-stack test SWC is not capable of handling it and we cannot fix it * Improve coverage * re-enable repl-artefacts workflow * Fix test * Preload wasm file in docs * docs: add functions to get full path of url * Delete the build plugin handleImportMetaUrl * Make 'npm install github/branch' work * Verify there is a valid changelog entry before releasing * Create release notes and comments from CI Minor change to maybe trigger a CI run * Fix RegExp * 4.0.0-14 * Minor changes for a test PR (#5139) * Fix RegExp use * 4.0.0-15 * Do not rely on current branch to find the PR * 4.0.0-16 * Fix how to determine git commit range * 4.0.0-17 * Make sure we fetch all history on publish * 4.0.0-18 * Add proper permissions * 4.0.0-19 * Use Double quotation marks instead of Single quotation marks if concurrently scripts with flags * Remove "engines" from native packages * Update CONTRIBUTING.md --------- Co-authored-by: XiaoPi <530257315@qq.com> * Update tests * Retrieve the code that was omitted during the merge * Restore test coverage * Update docs/plugin-development/index.md Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com> --------- Co-authored-by: Lukas Taegert-Atkinson <lukas.taegert-atkinson@tngtech.com> Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>

commit sha 62cbff4a20030c5d787f3162ea29981e40525030

[v4.0] Imporve the performance of generating ast and rollup ast nodes (#5144) * Set TsConfig useDefineForClassFields to false for reducing time consumption * Adapt annotations props for reducing memory consumption

commit sha 55abe0fbf7116c9160a53da6a27cc9bce2eafd40

[v4.0] Remove deprecated features (#5143) * Remove hasModuleSideEffects from module info * Remove this.moduleIds from plugin context * Remove output.preferConst * Remove output.dynamicImportFunction * Remove output.experimentalDeepDynamicChunkOptimization * Remove output.namespaceToStringTag * Remove inlineDynamicImports input option * Remove manualChunks and preserveModules input options as well as maxParallelFileReads

commit sha accd66a4247dfdb4d7f2605b399d12d001e5a3ed

[v4.0] feat: Do not watch files anymore if their content is returned by the load hook (#5150) * feat: Do not watch files anymore if their content is returned by the load hook * tweak test

commit sha 7325320ad95955540e1bb38dab9d600f569d915c

[v4.0] Remove onwarn from normalized input options (#5147) Remove onwarn from normalized input options Also remove the RollupWarning type

commit sha fda977bb38ab31638c3a4a18e0c4f8b9c8482e6c

[v4.0] Add parse option to allow return outside function (#5154) Allow return outside functions

commit sha 0b0eabd8cd93de7c6b69c95a4cac24559c040b80

[v4.0] Handle empty exports (#5157) Handle empty exports

push time in 2 days

delete branch rollup/rollup

delete branch : renovate/minorpatch-updates

delete time in 2 days

PR merged rollup/rollup

chore(deps): lock file maintenance minor/patch updates

This PR contains the following updates:

Package	Type	Update	Change	Pending
		lockFileMaintenance	All locks refreshed
@codemirror/language	devDependencies	patch	`^6.9.0` -> `^6.9.1`
@codemirror/search	devDependencies	patch	`^6.5.3` -> `^6.5.4`
@codemirror/view	devDependencies	patch	`^6.19.0` -> `^6.20.2`
@types/estree (source)	devDependencies	patch	`1.0.1` -> `1.0.2`
@types/node (source)	devDependencies	patch	`~14.18.61` -> `~14.18.63`
@types/yargs-parser (source)	devDependencies	patch	`^21.0.0` -> `^21.0.1`
@typescript-eslint/eslint-plugin	devDependencies	patch	`^6.7.2` -> `^6.7.3`
@typescript-eslint/parser	devDependencies	patch	`^6.7.2` -> `^6.7.3`
eslint (source)	devDependencies	minor	`^8.49.0` -> `^8.50.0`
rollup (source)	devDependencies	patch	`^3.29.2` -> `^3.29.3`	`3.29.4`
terser (source)	devDependencies	patch	`^5.19.4` -> `^5.20.0`
vitepress (source)	devDependencies	patch	`^1.0.0-rc.14` -> `^1.0.0-rc.20`

🔧 This Pull Request updates lock files to use the latest dependency versions.

Release Notes

<details> <summary>codemirror/view (@codemirror/view)</summary>

`v6.20.2`

Bug fixes

Fix an issue in the way the DOM selection is being read that could break backspacing of widgets on Android.

Fix a bug where the editor could incorrectly computate its transform scale when it was small.

`v6.20.1`

Bug fixes

Fix a crash in plugin event handlers after dynamic reconfiguration.

Fix an issue where, on Chrome, tooltips would no longer use fixed positioning.

</details>

<details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary>

`v6.7.3`

Note: Version bump only for package @typescript-eslint/eslint-plugin

You can read about our versioning strategy and releases on our website.

</details>

<details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary>

`v6.7.3`

Note: Version bump only for package @typescript-eslint/parser

You can read about our versioning strategy and releases on our website.

</details>

<details> <summary>eslint/eslint (eslint)</summary>

`v8.50.0`

Features

27d5a9e feat: add suggestions to array-callback-return (#17590) (Tanuj Kanti)
f9082ff feat: flat-rule-tester make sure default config always matches (#17585) (fnx)
83914ad feat: Implement SourceCode#applyInlineConfig() (#17351) (Nicholas C. Zakas)
22a5582 feat: add rule no-object-constructor, deprecate no-new-object (#17576) (Francesco Trotta)
85a3d9e feat: allowVoid option in array-callback-return (#17564) (Tanuj Kanti)

Bug Fixes

cc4d26b fix: Ensure deprecated context.parserServices warns (#17593) (Nicholas C. Zakas)
1ea4cfb fix: Ensure all RuleTester tests all deprecated context methods (#17587) (Nicholas C. Zakas)
aa1b657 fix: wrong suggestion and message in no-misleading-character-class (#17571) (Yosuke Ota)

Documentation

1800537 docs: Fix and standardize JSX code examples (#17591) (Francesco Trotta)
48a44a7 docs: Add correct/incorrect tags to prefer-arrow-callback (#17589) (Francesco Trotta)
20893d4 docs: fix incorrect tag's place (#17575) (Tanuj Kanti)
bd7a71f docs: Update README (GitHub Actions Bot)

Chores

f8a8a2d chore: upgrade @eslint/js @8.50.0 (#17599) (Milos Djermanovic)
38ada6d chore: package.json update for @eslint/js release (ESLint Jenkins)

</details>

<details> <summary>rollup/rollup (rollup)</summary>

`v3.29.3`

2023-09-24

Bug Fixes

Fix a bug where code was wrongly tree-shaken after mutating function parameters (#5153)

Pull Requests

#5145: docs: improve the docs repl appearance in the light mode (@TrickyPi)
#5148: chore(deps): update dependency @vue/eslint-config-typescript to v12 (@renovate[bot])
#5149: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5153: Fully deoptimize first level path when deoptimizing nested parameter paths (@lukastaegert)

</details>

<details> <summary>vuejs/vitepress (vitepress)</summary>

`v1.0.0-rc.20`

[v4.0] feat: migrate the encoding format of sha256 from hex to base64url for file name

Bug Fixes

build: consistent route.path across dev and ssr (#2997) (0d56855)
build: don't show missing lang warnings with text specifiers in fences (aa40cec)
handle references in container titles (7fbfe71), closes #3004
hmr: handle hmr in imported code snippets (#3005) (e84f313)
snippet hmr not working with rewrites (a275049)
selectively pass env for container titles (1a9c32d), closes #3007
types: add RegExp to markdown's allowed attributes (#3008) (bc96b2b)

</details>

Configuration

📅 Schedule: Branch creation - "before 4am on Friday" (UTC), Automerge - "after 10am on Friday" (UTC).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

+210 -177

1 commit in rollup/rollup/tree/renovate/minorpatch-updates rollup/rollup/tree/master

3 comments

2 changed files

renovate[bot]

pr closed time in 2 days

PullRequestReviewEvent

Pull request review commentrollup/rollup

 import { isPathFragment } from './relativeId'; import { makeUnique, renderNamePattern } from './renderNamePattern';  function getSourceHash(source: string | Uint8Array): string {-	return createHash().update(source).digest('hex');+	return createHash().update(source).digest('base64url');

Yes, let's go with this. We cannot sell it as a performance improvement yet, but it is simple for us and we have the breaking changes covered 👍.

TrickyPi

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentrollup/rollup

[v4.0] feat: migrate the encoding format of sha256 from hex to base64url for file name

 import { isPathFragment } from './relativeId'; import { makeUnique, renderNamePattern } from './renderNamePattern';  function getSourceHash(source: string | Uint8Array): string {-	return createHash().update(source).digest('hex');+	return createHash().update(source).digest('base64url');

That would be nice, but I am not sure we want to have both a native and a WASM artifact for the non-WASM Node build. At least I assume that would very much complicate the build process.

TrickyPi

comment created time in 3 days

PullRequestReviewEvent

created tagrollup/rollup

tagv3.29.4

Next-generation ES module bundler

created time in 3 days

push eventrollup/rollup

commit sha a6448b99f725d457e35821b73a865b5c4d4c6a61

3.29.4

push time in 3 days

push eventrollup/rollup

commit sha 4e92d60fa90cead39481e3703d26e5d812f43bd1

Deoptimize all parameters when losing track of a function (#5158)

commit sha a6448b99f725d457e35821b73a865b5c4d4c6a61

3.29.4

push time in 3 days

delete branch rollup/rollup

delete branch : gh-5156-treeshake-if

delete time in 3 days

push eventrollup/rollup

commit sha 4e92d60fa90cead39481e3703d26e5d812f43bd1

Deoptimize all parameters when losing track of a function (#5158)

Treeshaking wrongly removes `if` statement

push time in 3 days

issue closedrollup/rollup

Rollup Version

v3.29.3

Operating System (or Browser)

everywhere

Node Version (if applicable)

No response

Link To Reproduction

https://rollupjs.org/repl/?version=3.29.3&shareable=JTdCJTIyZXhhbXBsZSUyMiUzQW51bGwlMkMlMjJtb2R1bGVzJTIyJTNBJTVCJTdCJTIyY29kZSUyMiUzQSUyMiUyRiUyRiUyMFRSRUUtU0hBS0lORyU1Q24lNUNuJTIwZXhwb3J0JTIwZnVuY3Rpb24lMjBidWlsZEVsZW1lbnRDYWxsKHVwZGF0ZVN0YXRlJTJDJTIwc2lkZUVmZmVjdHMpJTIwJTdCJTVDbiUyMCUyMCUyMCUyMGNvbnN0JTIwc3RhdGUlMjAlM0QlMjAlN0IlMjBwdXJlJTNBJTIwZmFsc2UlMjAlN0QlM0IlNUNuJTIwJTIwJTIwJTIwdXBkYXRlU3RhdGUoc3RhdGUpJTNCJTIwJTJGJTJGJTIwU2V0JTIwc3RhdGUucHVyZSUyMCUzRCUyMHRydWUlNUNuJTIwJTIwJTIwJTIwaWYlMjAoc3RhdGUucHVyZSklMjBzaWRlRWZmZWN0cygpJTNCJTVDbiUyMCUyMCU3RCUyMiUyQyUyMmlzRW50cnklMjIlM0F0cnVlJTJDJTIybmFtZSUyMiUzQSUyMm1haW4uanMlMjIlN0QlNUQlMkMlMjJvcHRpb25zJTIyJTNBJTdCJTIyb3V0cHV0JTIyJTNBJTdCJTIyZm9ybWF0JTIyJTNBJTIyZXMlMjIlN0QlMkMlMjJ0cmVlc2hha2UlMjIlM0F0cnVlJTdEJTdE

Expected Behaviour

The if (state.pure) statement should not be dropped

Actual Behaviour

It is dropepd

@lukastaegert Guy told me to ping you :)

closed time in 3 days

nicolo-ribaudo

PR merged rollup/rollup

Deoptimize all parameters when losing track of a function

<!-- ⚡️ katchow! We ❤️ Pull Requests!

If you remove or skip this template, you'll make the 🐼 sad and the mighty god of Github will appear and pile-drive the close button from a great height while making animal noises.

Pull Request Requirements:

Please include tests to illustrate the problem this PR resolves.
Please lint your changes by running npm run lint before creating a PR.
Please update the documentation in /docs where necessary

Please place an x (no spaces - [x]) in all [ ] that apply. -->

This PR contains:

[x] bugfix
[ ] feature
[ ] refactor
[ ] documentation
[ ] other

Are tests included?

[x] yes (bugfixes and features will not be merged without tests)
[ ] no

Breaking Changes?

[ ] yes (breaking changes will not be merged unless absolutely necessary)
[x] no

List any relevant issue numbers:

resolves #5156

<!-- If this PR resolves any issues, list them as

resolves #1234

where 1234 is the issue number. This will help us with house-keeping as Github will automatically add a note to those issues stating that a potential fix exists. Once the PR is merged, Github will automatically close those issues.

If an issue is only solved partially or is relevant in some other way, just list the number without "resolves". -->

Description

I wonder why this did not turn up earlier. Basically we need to assume a function can be called with arbitrary values when we lose track of it e.g. because it is exported.

+23 -1

1 commit in rollup/rollup/tree/gh-5156-treeshake-if rollup/rollup/tree/master

3 comments

3 changed files

lukastaegert

pr closed time in 3 days

issue commentrollup/rollup

Handling of import assertions

Ok, it seems that there is no easy way to implement this without breaking most plugins. To not further block the release, we are unfortunately removing this from the Rollup 4 feature list for now 😞

thepassle

comment created time in 3 days

Pull request review commentrollup/rollup

[v4.0] feat: migrate the encoding format of sha256 from hex to base64url for file name

 import { isPathFragment } from './relativeId'; import { makeUnique, renderNamePattern } from './renderNamePattern';  function getSourceHash(source: string | Uint8Array): string {-	return createHash().update(source).digest('hex');+	return createHash().update(source).digest('base64url');

I had a look at node.js, I found that the loading logic is different between addon and node:crypto, addon is loaded by process.dlopen, but node:cypto is loaded by internalBinding, is this a possible reason?

Maybe, but isn't loading happening only once? Or is it calling process.dlopen for every CALL to the hashing function? In your test, how often is the function called?

Otherwise, this looks slightly disappointing. For the long-term perspective, it would be good to have the hashing implementation in Rust as then, we can easily move calls from JS to Rust. But this is not relevant now. So if we really want to be fast, we could use xxhash-wasm for all Node versions, keeping it as an external dependency, but use either a Rust version or maybe just xxhash-js for the browser build. What do you think? We use the 128bit version and limit hash length to 21 characters so we should have all breaking changes covered. And we might need to convert to base64 manually if it is not provided out-of-the-box.

TrickyPi

comment created time in 3 days

PullRequestReviewEvent

push eventTNG/next-generation-scrum-poker

dependabot[bot]

commit sha 5c408bc99e1358af05f0aab1bf0a25478c6c1e26

Bump get-func-name from 2.0.0 to 2.0.2 Bumps [get-func-name](https://github.com/chaijs/get-func-name) from 2.0.0 to 2.0.2. - [Release notes](https://github.com/chaijs/get-func-name/releases) - [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2) --- updated-dependencies: - dependency-name: get-func-name dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

commit sha 62c92836a0b46da171a8e72abd091317174a6493

Merge pull request #129 from TNG/dependabot/npm_and_yarn/get-func-name-2.0.2 Bump get-func-name from 2.0.0 to 2.0.2

fix(alias,auto-install,babel,beep,buble,commonjs,data-uri,dsv,dynamic-import-vars,eslint,esm-shim,graphql,html,image,inject,json,legacy,multi-entry,node-resolve,pluginutils,replace,run,strip,sucrase,swc,terser,typescript,url,virtual,wasm,yaml): ensure rollup 4 compatibility

push time in 3 days

delete branch TNG/next-generation-scrum-poker

delete branch : dependabot/npm_and_yarn/get-func-name-2.0.2

delete time in 3 days

PR merged TNG/next-generation-scrum-poker

Bump get-func-name from 2.0.0 to 2.0.2 dependencies

Bumps get-func-name from 2.0.0 to 2.0.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/chaijs/get-func-name/releases">get-func-name's releases</a>.</em></p> <blockquote> <h2>v2.0.2</h2> <h2>What's Changed</h2> <p>Revert previous changes that shipped this as an ES module.</p> <p><strong>Full Changelog</strong>: <a href="https://github.com/chaijs/get-func-name/commits/v2.0.2">https://github.com/chaijs/get-func-name/commits/v2.0.2</a></p> <h2>v2.0.1</h2> <h2>What's Changed</h2> <p>Fix <a href="https://github.com/chaijs/get-func-name/security/advisories/GHSA-4q6p-r6v2-jvc5">https://github.com/chaijs/get-func-name/security/advisories/GHSA-4q6p-r6v2-jvc5</a></p> <p><strong>Full Changelog</strong>: <a href="https://github.com/chaijs/get-func-name/commits/v2.0.1">https://github.com/chaijs/get-func-name/commits/v2.0.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/chaijs/get-func-name/commits/v2.0.2">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~keithamus">keithamus</a>, a new releaser for get-func-name since your current version.</p> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

1 commit in TNG/next-generation-scrum-poker/tree/dependabot/npm_and_yarn/get-func-name-2.0.2 TNG/next-generation-scrum-poker/tree/master

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 days

PullRequestReviewEvent

pull request commentrollup/plugins

The failing windows ci should not be related to the changes

That would be a relief, but why is it failing? Is it broken on master?

lukastaegert

comment created time in 3 days

Pull request review commentrollup/rollup

[v4.0] feat: migrate the encoding format of sha256 from hex to base64url for file name

 import { isPathFragment } from './relativeId'; import { makeUnique, renderNamePattern } from './renderNamePattern';  function getSourceHash(source: string | Uint8Array): string {-	return createHash().update(source).digest('hex');+	return createHash().update(source).digest('base64url');

Wow, that was quite some digging. I see you also discovered a much better hashing algorithm. I wonder one thing, though: Why is Node:crypto still so fast? Don't they also need to pass a JavaScript string to a native addon? Or do they have access to some dark magic that we are missing? Question: How does performance change if you convert the string to a Buffer via Buffer.from(string) and pass and hash that Buffer instead? Does that improve Napi performance? Does it make a difference to use Buffer.from(string, 'utf16le') and hash that?

TrickyPi

comment created time in 3 days

PullRequestReviewEvent

push eventrollup/plugins

commit sha 59c61515080cb7fde65b879b7389ae45851fb662

fix(alias,auto-install,babel,beep,buble,commonjs,data-uri,dsv,dynamic-import-vars,eslint,esm-shim,graphql,html,image,inject,json,legacy,multi-entry,node-resolve,pluginutils,replace,run,strip,sucrase,swc,terser,typescript,url,virtual,wasm,yaml): ensure rollup 4 compatibility