profile
viewpoint
Mark Dalgleish markdalgleish @remix-run Melbourne, Australia markdalgleish.com 🦄 CSS Modules co-creator / 🧁 Vanilla Extract / Creator of Braid, Playroom / MelbJS organiser / 💿 @remix-run at @shopify 🛍️

KyleAMathews/superagent-bluebird-promise 184

Add promise support to superagent using Bluebird

cssinjs/jss-loader 65

JSS Loader for Webpack

markdalgleish/astro-vanilla-extract-demo 17

Basic demo of Astro and vanilla-extract

alexanderdickson/Stunts 12

A "HTML5" implementation of Stunts

markdalgleish/allthethings.js 11

Let your array iterations read like actual sentences

jacob-ebey/rsc-webpack-playground 9

RSC On Webpack + @remix-run/router

markdalgleish/bespoke-remote-prototype 7

Prototype presentation for bespoke-remote

markdalgleish/angular-delegator 6

Write smaller, cleaner AngularJS services

markdalgleish/awesome-design-systems 5

💅🏻 ⚒ A collection of awesome design systems

markdalgleish/batsignal 5

Help radiator for remote agile teams. Built using Meteor.

push eventremix-run/remix

Mark Dalgleish

commit sha 7bd45700083d2fc2307f62563e20370c42978239

fix PostCSS context value, improve type checking

view details

push time in 6 hours

push eventremix-run/remix

Mark Dalgleish

commit sha 9bfb081275679495d9c62faba9bae3a49ecc03ff

fix type error in Vanilla Extract plugin

view details

push time in 6 hours

PullRequestReviewEvent

Pull request review commentremix-run/remix

feat(remix-dev): introduce `serverNodeBuiltinsPolyfill` config option + replace `esbuild-plugin-polyfill-node` with `esbuild-plugins-node-modules-polyfill`

 export const serverModuleFormatWarning =   "For instructions on making this change see " +   "https://remix.run/docs/en/v1.16.0/pages/v2#servermoduleformat"; +export const serverNodeBuiltinsPolyfillWarning =+  "⚠️ REMIX FUTURE CHANGE: The `serverNodeBuiltinsPolyfill` config default option will be changing in v2 " ++  "from `true` to `false` regardless of platform. You can prepare for this change by explicitly specifying " ++  "serverNodeBuiltinsPolyfill: false` or `serverNodeBuiltinsPolyfill: true` if you are currently relying on them. " ++  "For instructions on making this change see " ++  "https://remix.run/docs/en/v1.16.0/pages/v2#servernodebuiltinspolyfill";

This version number needs to be bumped to match the version this goes out in.

jacob-ebey

comment created time in 7 hours

PullRequestReviewEvent

PR opened remix-run/remix

fix(dev): cache PostCSS for side-effect imports package:dev

This PR centralises the caching logic introduced in #6505 and adapts the CSS side-effect import plugin to make use of it.

I've updated the HMR test to include a CSS side-effect import so that caching bugs get picked up. I've also added a PostCSS config to the deterministic build output test to ensure paths are handled correctly when using PostCSS.

+174 -130

0 comment

6 changed files

pr created time in 7 hours

push eventremix-run/remix

Mark Dalgleish

commit sha 4f2483be3bfd41f2a06fcda570cf441ad8cd10ae

fix(dev): cache PostCSS for side-effect imports

view details

push time in 7 hours

push eventremix-run/remix

Michaël De Boey

commit sha 657fcba3879d80636f8ed464d839503ead383248

docs: use TS files where possible (#6334)

view details

Matt Brophy

commit sha fb74cb68792d26a2119c55bc7cc93abcca3435b2

Merge branch 'release-next'

view details

Ryan Florence

commit sha cb7a4e8fd2f3f6cf6840672905a7bf8e032849c7

Update api-development-strategy.md

view details

Furkan Akkurt

commit sha 1bf771c45dba841c6bec4709717bc7fcde0e09e5

docs: fix typos (#6446)

view details

MohammadReza Khosravian

commit sha 6ddf20c533512bc9afb75b7102b776975d86875b

docs(file-conventions/route-files-v2): fix code highlighting (#6442)

view details

Stephan Meijer

commit sha 96ad9e315f0489c39babb2e6eb7931ce81401ec9

docs: fix typo in jokes app tutorial (#6461)

view details

Amir Ziaei

commit sha 7a686ce84d8fda0e0215c64ed3610de15f246f8c

templates: improve Lighthouse SEO score (#6377) Co-authored-by: Amir Ziaei <amir.ziaei@zenitech.co.uk> Co-authored-by: Matt Brophy <matt@brophy.org>

view details

Andrew Torres

commit sha fc461300df234311f4159b587e983725e659eb2c

docs(guides/not-found): fix typo (#6482)

view details

Vincent Taneri

commit sha 189c7b8820dc736ccb61564d1c1465f50c17d5a9

docs(tutorials/jokes): fix code highlighting (#6473)

view details

Alastair Lockie

commit sha 3239ba93adac97248a21b82d464944d4d2b05f1e

docs(hooks/use-matches): fix code highlighting (#6487)

view details

Michaël De Boey

commit sha f0e4b941b8d8f7815dbfb3c6bef5bc57133abd5b

templates: have `loadContext` available in `handleRequest` (#6190)

view details

Remix Run Bot

commit sha 1391efd1f4a2303a1f065c1bd26bca423102b0a4

chore: format

view details

Michaël De Boey

commit sha a3e41e6414fd6f3be4904b94a9bae0fd49626be1

chore: use globs in Deno scripts (#6486)

view details

Michaël De Boey

commit sha 761fc1d867b674e8c00268c263675fe04f43a10a

docs(guides/migrating-react-router-app): mention `_index` file (#6489)

view details

Shining Love Star

commit sha 880ab96ba02ac1d565028c9c8cbf9d98ca1edeb3

docs(tutorials/jokes): fix `getUser` function (#6499) Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

view details

Matt Brophy

commit sha ca0133e5fc8c4d46ae8ab45ecfee0a1dd73855ef

Merge branch 'main' into release-next

view details

Matt Brophy

commit sha 3c8d03992f354801af85800056ca875966aae3d3

Enter prerelease mode

view details

github-actions[bot]

commit sha 3b435ebeb5619dd19b19f152e0c23145b49839d7

chore: Update version for release (pre) (#6526) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

view details

Matt Brophy

commit sha fc7dc920dedb732bc96ddd38a15a54d3087017e4

Bump to react-router stable 6.12.0 version (#6548)

view details

github-actions[bot]

commit sha 2ce34bada1af61f6fcc7a942a0975c62a7328c37

chore: Update version for release (pre) (#6549) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

view details

push time in 7 hours

push eventremix-run/remix

Mark Dalgleish

commit sha 3a3da5ae3d69b1e378a224652dcf0adee357bd55

fix package.json

view details

push time in 9 hours

push eventremix-run/remix

Michaël De Boey

commit sha 657fcba3879d80636f8ed464d839503ead383248

docs: use TS files where possible (#6334)

view details

Matt Brophy

commit sha fb74cb68792d26a2119c55bc7cc93abcca3435b2

Merge branch 'release-next'

view details

Ryan Florence

commit sha cb7a4e8fd2f3f6cf6840672905a7bf8e032849c7

Update api-development-strategy.md

view details

Furkan Akkurt

commit sha 1bf771c45dba841c6bec4709717bc7fcde0e09e5

docs: fix typos (#6446)

view details

MohammadReza Khosravian

commit sha 6ddf20c533512bc9afb75b7102b776975d86875b

docs(file-conventions/route-files-v2): fix code highlighting (#6442)

view details

Stephan Meijer

commit sha 96ad9e315f0489c39babb2e6eb7931ce81401ec9

docs: fix typo in jokes app tutorial (#6461)

view details

Amir Ziaei

commit sha 7a686ce84d8fda0e0215c64ed3610de15f246f8c

templates: improve Lighthouse SEO score (#6377) Co-authored-by: Amir Ziaei <amir.ziaei@zenitech.co.uk> Co-authored-by: Matt Brophy <matt@brophy.org>

view details

Andrew Torres

commit sha fc461300df234311f4159b587e983725e659eb2c

docs(guides/not-found): fix typo (#6482)

view details

Vincent Taneri

commit sha 189c7b8820dc736ccb61564d1c1465f50c17d5a9

docs(tutorials/jokes): fix code highlighting (#6473)

view details

Alastair Lockie

commit sha 3239ba93adac97248a21b82d464944d4d2b05f1e

docs(hooks/use-matches): fix code highlighting (#6487)

view details

Michaël De Boey

commit sha f0e4b941b8d8f7815dbfb3c6bef5bc57133abd5b

templates: have `loadContext` available in `handleRequest` (#6190)

view details

Remix Run Bot

commit sha 1391efd1f4a2303a1f065c1bd26bca423102b0a4

chore: format

view details

Michaël De Boey

commit sha a3e41e6414fd6f3be4904b94a9bae0fd49626be1

chore: use globs in Deno scripts (#6486)

view details

Michaël De Boey

commit sha 761fc1d867b674e8c00268c263675fe04f43a10a

docs(guides/migrating-react-router-app): mention `_index` file (#6489)

view details

Shining Love Star

commit sha 880ab96ba02ac1d565028c9c8cbf9d98ca1edeb3

docs(tutorials/jokes): fix `getUser` function (#6499) Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

view details

Matt Brophy

commit sha ca0133e5fc8c4d46ae8ab45ecfee0a1dd73855ef

Merge branch 'main' into release-next

view details

Matt Brophy

commit sha 3c8d03992f354801af85800056ca875966aae3d3

Enter prerelease mode

view details

github-actions[bot]

commit sha 3b435ebeb5619dd19b19f152e0c23145b49839d7

chore: Update version for release (pre) (#6526) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

view details

Matt Brophy

commit sha fc7dc920dedb732bc96ddd38a15a54d3087017e4

Bump to react-router stable 6.12.0 version (#6548)

view details

github-actions[bot]

commit sha 2ce34bada1af61f6fcc7a942a0975c62a7328c37

chore: Update version for release (pre) (#6549) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

view details

push time in 9 hours

push eventremix-run/remix

Mark Dalgleish

commit sha 23d1c3c6ed8867b14914638e5f973e7a17ca99ec

fix(dev): cache PostCSS for side-effect imports

view details

push time in a day

push eventremix-run/remix

Mark Dalgleish

commit sha 9506d0f4d8d14e53bd567ab3a87e078d7625122c

fix(dev): fix CSS import warnings in unstable_dev (#6506)

view details

Mark Dalgleish

commit sha 70cc6278c27b4e170f68f27f747618c0ce77c848

chore: fix copy-build-to-dist script on Windows (#6518)

view details

Matt Brophy

commit sha 360cd949ab5365f2a64a91f012285c5c99cad843

Bump to router prerelease (#6517) Co-authored-by: Jacob Ebey <jacob.ebey@live.com>

view details

Matt Brophy

commit sha 5fbb9b40f8f0bffbb72a004b2b9b2ebc77357cc1

rename onUnhandledError - > handleError (#6524)

view details

Remix Run Bot

commit sha 4b7ac408efa154c4933a6b7f334bd558629736b5

chore: format

view details

Matt Brophy

commit sha 45a91e075a55ac55d0b3472701dac32af7c36eac

Drop css caching to minor changeset

view details

Mark Dalgleish

commit sha 6d7552c68cae7041ef9abdc877addd26698915f1

Merge branch 'dev' into markdalgleish/lazy-css-bundle

view details

push time in 2 days

PR opened remix-run/remix

Reviewers
fix(dev): lazily generate CSS bundle package:dev package:css-bundle

In order to improve build performance of Remix projects that aren't using CSS bundling features, this PR modifies the compiler so that the CSS bundle build (which is a separate esbuild compilation) isn't started until an import of @remix-run/css-bundle is detected in the client and server builds.

Since the cssBundleHref value is now entirely managed by an esbuild plugin, it's no longer part of the Remix manifest. This meant that the css-bundle package could be simplified. It no longer reads the manifest which means it doesn't depend on @remix-run/dev anymore, and it doesn't need to have different logic for client and server, so it can now be expressed in a single index.ts file.

+187 -157

0 comment

16 changed files

pr created time in 2 days

push eventremix-run/remix

Mark Dalgleish

commit sha 98a6e528a9087c298d33d6aba973f05ede3e974f

fix(dev): lazily generate CSS bundle

view details

push time in 2 days

create barnchremix-run/remix

branch : markdalgleish/lazy-css-bundle

created branch time in 2 days

delete branch remix-run/remix

delete branch : markdalgleish/fix-copy-dist-windows

delete time in 5 days

push eventremix-run/remix

Mark Dalgleish

commit sha 70cc6278c27b4e170f68f27f747618c0ce77c848

chore: fix copy-build-to-dist script on Windows (#6518)

view details

push time in 5 days

PR merged remix-run/remix

chore: fix copy-build-to-dist script on Windows CLA Signed

I ran into this issue while working on #6509 which resulted in tests failing on Windows in CI. Since that PR is now closed, I've pulled out this fix into its own PR.

+3 -3

1 comment

1 changed file

markdalgleish

pr closed time in 5 days

push eventremix-run/remix

Mark Dalgleish

commit sha 9506d0f4d8d14e53bd567ab3a87e078d7625122c

fix(dev): fix CSS import warnings in unstable_dev (#6506)

view details

Mark Dalgleish

commit sha d3bf06383d4748793294711d1d56a3af22dfe69c

Merge branch 'dev' into markdalgleish/fix-copy-dist-windows

view details

push time in 5 days

delete branch remix-run/remix

delete branch : markdalgleish/fix-unresolved-css-import-warnings

delete time in 5 days

push eventremix-run/remix

Mark Dalgleish

commit sha 9506d0f4d8d14e53bd567ab3a87e078d7625122c

fix(dev): fix CSS import warnings in unstable_dev (#6506)

view details

push time in 5 days

PR merged remix-run/remix

Reviewers
fix(dev): fix CSS import warnings in unstable_dev CLA Signed

Closes #6502

I verified this by running it against the library mentioned in the linked issue.

@pcattori I remember you mentioning that this area will get some more attention, but just raising a quick fix for now in case we want to ship this in the meantime.

+11 -1

1 comment

2 changed files

markdalgleish

pr closed time in 5 days

push eventremix-run/remix

Mark Dalgleish

commit sha 408ebf88e40fff73e161305e1e7dcc4c1f6271dc

test: allow config overrides for Playwright tests (#6508)

view details

Mark Dalgleish

commit sha a6b5532cf6187319318ea635c93b8da3673c3de2

refactor: clean up leftover debugging code (#6510)

view details

Michaël De Boey

commit sha 76218ed0e9e921f4778655bf49da273c9704412e

templates: enable `v2_headers` future flag (#6490)

view details

Michaël De Boey

commit sha 65d601c93df277a4909973bb966f44d997ddb4fa

fix(remix-dev): loosen `prettier` version (#6488)

view details

Michaël De Boey

commit sha 92a570ee7773242064d50bd0b7a5e406f4f3eb22

refactor(remix-react): remove unnecessary type-checks (#6323)

view details

Remix Run Bot

commit sha 08aedc4e37b9f8ec86472e6de571fd34233ad628

chore: format

view details

Jacob Ebey

commit sha 7fc2d141f5a51b3ae60fa8de5d2c6dda9dc5d21a

fix(remix-node): fix `NodeRequest`'s `clone` function (#6512) Co-authored-by: Tomer Yechiel <tomer.yechiel@gmail.com>

view details

Jacob Ebey

commit sha 90cbe9a16a77b0cb03b36916e160038ac195528f

feat: retry failed revalidation caused by HDR (#6287)

view details

Matt Brophy

commit sha c6d8c37a8439e7d9edeac6e948595f29f35f7cc9

Fix server error logging and add onUnhandledError support (#6495)

view details

Remix Run Bot

commit sha 27d350ad8af112ca0f2b9e279aa33e65d0a403d0

chore: format

view details

Mark Dalgleish

commit sha ce07e84a63eaa99d020f2a3856ab8f5aa9b3d63d

fix: add caching to PostCSS for regular stylesheets (#6505)

view details

Mark Dalgleish

commit sha 7d8b792a7d905763014e0f7d6c505f05b0fb0ac1

Merge branch 'dev' into markdalgleish/fix-unresolved-css-import-warnings

view details

push time in 5 days

PR opened remix-run/remix

chore: fix copy-build-to-dist script on Windows

I ran into this issue while working on #6509 which resulted in tests failing on Windows in CI. Since that PR is now closed, I've pulled out this fix into its own PR.

+3 -3

0 comment

1 changed file

pr created time in 5 days

create barnchremix-run/remix

branch : markdalgleish/fix-copy-dist-windows

created branch time in 5 days

PR closed remix-run/remix

fix(dev): skip CSS build on missing css-bundle dep CLA Signed package:dev package:css-bundle

Since you can only access the output of the CSS bundle build via the @remix-run/css-bundle package, we can detect the lack of this package and use this to avoid running an esbuild pass for no reason.

To make this easier to test (since our monorepo unavoidably has this package available), and also to give consumers more explicit control over this behaviour, I've added a cssBundle option to the Remix config, but I'm leaving it undocumented for now.

+91 -24

3 comments

16 changed files

markdalgleish

pr closed time in 5 days

pull request commentremix-run/remix

fix(dev): skip CSS build on missing css-bundle dep

Closing for now since we're going to try a different approach.

markdalgleish

comment created time in 5 days

push eventremix-run/remix

Mark Dalgleish

commit sha 37827d057f5ee1f093d79a0f7a9ae9500ee1dd9a

add docs

view details

push time in 5 days

push eventremix-run/remix

Jacob Ebey

commit sha 7fc2d141f5a51b3ae60fa8de5d2c6dda9dc5d21a

fix(remix-node): fix `NodeRequest`'s `clone` function (#6512) Co-authored-by: Tomer Yechiel <tomer.yechiel@gmail.com>

view details

Jacob Ebey

commit sha 90cbe9a16a77b0cb03b36916e160038ac195528f

feat: retry failed revalidation caused by HDR (#6287)

view details

Matt Brophy

commit sha c6d8c37a8439e7d9edeac6e948595f29f35f7cc9

Fix server error logging and add onUnhandledError support (#6495)

view details

Remix Run Bot

commit sha 27d350ad8af112ca0f2b9e279aa33e65d0a403d0

chore: format

view details

Mark Dalgleish

commit sha ce07e84a63eaa99d020f2a3856ab8f5aa9b3d63d

fix: add caching to PostCSS for regular stylesheets (#6505)

view details

Mark Dalgleish

commit sha 0d0e026dea28f851f3e6ecd2844090333c79ec73

Merge branch 'dev' into markdalgleish/skip-css-build

view details

push time in 5 days

more