nodejs/docker-node 7652
Official Docker Image for Node.js :whale: :turtle: :rocket:
nodejs/nan 3154
Native Abstractions for Node.js
nodejs/nodejs.org 2596
The Node.js® Website
nodejs/llnode 1065
An lldb plugin for Node.js and V8, which enables inspection of JavaScript states for insights into Node.js processes and their core dumps.
@nodejs-github-bot's heart and soul
Primary source of truth for the Docker "Official Images" program
pull request commentnodejs/node
[v19.x] deps: V8: cherry-pick f09dde9fbb54
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5255/
comment created time in 5 hours
pull request commentnodejs/node
test: run WPT files in parallel again
CI: https://ci.nodejs.org/job/node-test-pull-request/50647/
comment created time in 5 hours
pull request commentnodejs/node
[v19.x] deps: V8: cherry-pick f09dde9fbb54
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5255/
comment created time in 5 hours
pull request commentnodejs/node
[v19.x] deps: V8: cherry-pick f09dde9fbb54
CI: https://ci.nodejs.org/job/node-test-pull-request/50646/
comment created time in 5 hours
pull request commentnodejs/node
quic: implement various utilities classes to be used by the quic impl
CI: https://ci.nodejs.org/job/node-test-pull-request/50645/
comment created time in 6 hours
pull request commentnodejs/node
quic: implement various utilities classes to be used by the quic impl
CI: https://ci.nodejs.org/job/node-test-pull-request/50644/
comment created time in 6 hours
pull request commentnodejs/node
CI: https://ci.nodejs.org/job/node-test-pull-request/50643/
comment created time in 7 hours
pull request commentnodejs/node
CI: https://ci.nodejs.org/job/node-test-pull-request/50643/
comment created time in 7 hours
pull request commentnodejs/node
CI: https://ci.nodejs.org/job/node-test-pull-request/50643/
comment created time in 7 hours
pull request commentnodejs/node
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5254/
comment created time in 7 hours
pull request commentnodejs/node
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5254/
comment created time in 7 hours
pull request commentnodejs/node
CI: https://ci.nodejs.org/job/node-test-pull-request/50642/
comment created time in 7 hours
pull request commentnodejs/node
test_runner: expose reporter for use in run api
Landed in 29d7aecf42772e64f2202f854b51bbbee2f0f080
comment created time in 8 hours
issue closednodejs/node
Test runner run function crashing
Version
v18.15.0
Platform
Microsoft Windows NT 10.0.19045.0 x64
Subsystem
No response
What steps will reproduce the bug?
import { run } from 'node:test';
run({ files: [] }).pipe(process.stdout);
How often does it reproduce? Is there a required condition?
Always. Crashes as well when files is not empty.
What is the expected behavior? Why is that the expected behavior?
It shouldn't crash.
What do you see instead?
node:internal/test_runner/harness:45
throw err;
^
TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of Object
at new NodeError (node:internal/errors:399:5)
at _write (node:internal/streams/writable:315:13)
at Writable.write (node:internal/streams/writable:337:10)
at TestsStream.ondata (node:internal/streams/readable:766:22)
at TestsStream.emit (node:events:513:28)
at Readable.read (node:internal/streams/readable:539:10)
at flow (node:internal/streams/readable:1023:34)
at resume_ (node:internal/streams/readable:1004:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
code: 'ERR_INVALID_ARG_TYPE'
}
Additional information
No response
closed time in 8 hours
jeanbmarPR merged nodejs/node
Fixes: #47231 <!-- Before submitting a pull request, please read https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.
Commit message formatting guidelines: https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
For code changes:
- Include tests for any bug fixes or new features.
- Update documentation if relevant.
- Ensure that
make -j4 test
(UNIX), orvcbuild test
(Windows) passes.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->
pr closed time in 8 hours
push eventnodejs/node
commit sha 29d7aecf42772e64f2202f854b51bbbee2f0f080
test_runner: expose reporter for use in run api PR-URL: https://github.com/nodejs/node/pull/47238 Fixes: https://github.com/nodejs/node/issues/47231 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
push time in 8 hours
pull request commentnodejs/node
test_runner: expose reporter for use in run api
<details><summary>Commit Queue failed</summary><pre>- Loading data for nodejs/node/pull/47238 ✔ Done loading data for nodejs/node/pull/47238 ----------------------------------- PR info ------------------------------------ Title test_runner: expose reporter for use in run api (#47238) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch atlowChemi:expose-test-stream-reportes -> nodejs:main Labels test, author ready, needs-ci, test_runner Commits 7
- test_runner: expose reporter for use in run api
- test_runner: CR - fix lint error & cleaner UT
- test_runner: fix lint error
- test_runner: CR add UT & lazy require
- test_runner: CR cleanup
- fix test
- cr proto:null Committers 1
- atlowChemi chemi@testim.io PR-URL: https://github.com/nodejs/node/pull/47238 Fixes: https://github.com/nodejs/node/issues/47231 Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47238 Fixes: https://github.com/nodejs/node/issues/47231 Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
ℹ This PR was created on Thu, 23 Mar 2023 18:54:23 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47238#pullrequestreview-1358000643 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47238#pullrequestreview-1357856121 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-26T10:37:02Z: https://ci.nodejs.org/job/node-test-pull-request/50610/
- Querying data for job/node-test-pull-request/50610/ ✔ Last Jenkins CI successful
✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress
- Bringing origin/main up to date... From https://github.com/nodejs/node
- branch main -> FETCH_HEAD ✔ origin/main is now up-to-date
- Downloading patch for 47238 From https://github.com/nodejs/node
- branch refs/pull/47238/merge -> FETCH_HEAD ✔ Fetched commits as 67200dca0fd2..b123070defc7
[main 1a39fb64e5] test_runner: expose reporter for use in run api Author: atlowChemi chemi@testim.io Date: Thu Mar 23 20:48:33 2023 +0200 3 files changed, 52 insertions(+), 1 deletion(-) create mode 100644 lib/test/reporters.js [main 5f6542c932] test_runner: CR - fix lint error & cleaner UT Author: atlowChemi chemi@testim.io Date: Fri Mar 24 07:04:03 2023 +0200 2 files changed, 7 insertions(+), 16 deletions(-) [main d99211c5aa] test_runner: fix lint error Author: atlowChemi chemi@testim.io Date: Fri Mar 24 08:40:22 2023 +0200 2 files changed, 1 insertion(+), 1 deletion(-) [main e42165c99c] test_runner: CR add UT & lazy require Author: atlowChemi chemi@testim.io Date: Sat Mar 25 22:41:32 2023 +0300 3 files changed, 75 insertions(+), 10 deletions(-) [main 8b1a1492c0] test_runner: CR cleanup Author: atlowChemi chemi@testim.io Date: Sat Mar 25 23:01:57 2023 +0300 1 file changed, 26 insertions(+), 33 deletions(-) [main 4c47cce0df] fix test Author: atlowChemi chemi@testim.io Date: Sun Mar 26 10:02:06 2023 +0300 1 file changed, 1 deletion(-) [main 1dc8d05966] cr proto:null Author: atlowChemi chemi@testim.io Date: Sun Mar 26 10:11:14 2023 +0300 1 file changed, 1 insertion(+) ✔ Patches applied There are 7 commits in the PR. Attempting autorebase. Rebasing (2/14)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test_runner: expose reporter for use in run api
PR-URL: https://github.com/nodejs/node/pull/47238 Fixes: https://github.com/nodejs/node/issues/47231 Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
[detached HEAD 17ebcb8ccb] test_runner: expose reporter for use in run api Author: atlowChemi chemi@testim.io Date: Thu Mar 23 20:48:33 2023 +0200 3 files changed, 52 insertions(+), 1 deletion(-) create mode 100644 lib/test/reporters.js Rebasing (3/14) Rebasing (4/14)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test_runner: CR - fix lint error & cleaner UT
PR-URL: https://github.com/nodejs/node/pull/47238 Fixes: https://github.com/nodejs/node/issues/47231 Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
[detached HEAD 45ec6432e1] test_runner: CR - fix lint error & cleaner UT Author: atlowChemi chemi@testim.io Date: Fri Mar 24 07:04:03 2023 +0200 2 files changed, 7 insertions(+), 16 deletions(-) Rebasing (5/14) Rebasing (6/14)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test_runner: fix lint error
PR-URL: https://github.com/nodejs/node/pull/47238 Fixes: https://github.com/nodejs/node/issues/47231 Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
[detached HEAD fa49a0a106] test_runner: fix lint error Author: atlowChemi chemi@testim.io Date: Fri Mar 24 08:40:22 2023 +0200 2 files changed, 1 insertion(+), 1 deletion(-) Rebasing (7/14) Rebasing (8/14)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test_runner: CR add UT & lazy require
PR-URL: https://github.com/nodejs/node/pull/47238 Fixes: https://github.com/nodejs/node/issues/47231 Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
[detached HEAD 76aa1a9b1b] test_runner: CR add UT & lazy require Author: atlowChemi chemi@testim.io Date: Sat Mar 25 22:41:32 2023 +0300 3 files changed, 75 insertions(+), 10 deletions(-) Rebasing (9/14) Rebasing (10/14)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test_runner: CR cleanup
PR-URL: https://github.com/nodejs/node/pull/47238 Fixes: https://github.com/nodejs/node/issues/47231 Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
[detached HEAD 978cde4447] test_runner: CR cleanup Author: atlowChemi chemi@testim.io Date: Sat Mar 25 23:01:57 2023 +0300 1 file changed, 26 insertions(+), 33 deletions(-) Rebasing (11/14) Rebasing (12/14)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- fix test
PR-URL: https://github.com/nodejs/node/pull/47238 Fixes: https://github.com/nodejs/node/issues/47231 Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
[detached HEAD 138c71181c] fix test Author: atlowChemi chemi@testim.io Date: Sun Mar 26 10:02:06 2023 +0300 1 file changed, 1 deletion(-) Rebasing (13/14) Rebasing (14/14)
Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- cr proto:null
PR-URL: https://github.com/nodejs/node/pull/47238 Fixes: https://github.com/nodejs/node/issues/47231 Reviewed-By: Moshe Atlow moshe@atlow.co.il Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
[detached HEAD 15dccdc183] cr proto:null Author: atlowChemi chemi@testim.io Date: Sun Mar 26 10:11:14 2023 +0300 1 file changed, 1 insertion(+)
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash
label to land the PR as one commit, or commit-queue-rebase
to land as separate commits.</pre><a href='https://github.com/nodejs/node/actions/runs/4542737191'>https://github.com/nodejs/node/actions/runs/4542737191</a></details>
comment created time in 9 hours
pull request commentnodejs/node
build: avoid usage of pipes library
CI: https://ci.nodejs.org/job/node-test-pull-request/50641/
comment created time in 9 hours
pull request commentnodejs/node
CI: https://ci.nodejs.org/job/node-test-pull-request/50640/
comment created time in 9 hours
pull request commentnodejs/node
net: enable autoSelectFamily by default
CI: https://ci.nodejs.org/job/node-test-pull-request/50639/
comment created time in 10 hours
pull request commentnodejs/node
CI: https://ci.nodejs.org/job/node-test-pull-request/50638/
comment created time in 11 hours
pull request commentnodejs/node
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5251/
comment created time in 12 hours
pull request commentnodejs/node
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5251/
comment created time in 12 hours
pull request commentnodejs/node
CI: https://ci.nodejs.org/job/node-test-pull-request/50637/
comment created time in 12 hours
push eventnodejs/node-v8
commit sha f84ff93d96a02900f9fdd8233f6a0b0c2c534a11
doc: use serial comma in cli docs Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/47262 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
commit sha 13767a4675f28550e3720c46c5a16349b95283a9
test: fix test-child-process-exec-cwd Refs: https://github.com/nodejs/node/pull/47020 Refs: https://github.com/nodejs/build/issues/3046 PR-URL: https://github.com/nodejs/node/pull/47235 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
commit sha a4808b6c3b111608e0b9945c7f62534b285b0c96
deps: upgrade npm to 9.6.2 PR-URL: https://github.com/nodejs/node/pull/47108 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
commit sha 67200dca0fd22da14ba6e48a404ae2241d6cef81
deps: update timezone to 2023b PR-URL: https://github.com/nodejs/node/pull/47256 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
commit sha 454f56ca55672fd584ba57c329db3ac367306673
deps: update V8 to 11.4.12
commit sha 065a0299d8e43b162e47b8b40544703176cb4e7d
build: reset embedder string to "-node.0"
commit sha b5f25e984f7342f6be8bac0ec4f4e9fc252c8066
src: update NODE_MODULE_VERSION to 115 Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 11.4. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
commit sha 6a36a759fa5d10bf1f12362bf7fe5af4063a2fb9
deps: always define V8_EXPORT_PRIVATE as no-op dllexport introduces issues when compiling with MSVC.
commit sha 0badc20909ab92c210b22170742bc7a409f7dc3a
deps: silence irrelevant V8 warning PR-URL: https://github.com/nodejs/node/pull/45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
commit sha 916f8566324788dddea62a68cab57e54a9f320c0
tools: update V8 gypfiles for 11.0
commit sha f01f580b06f8c04b9349d174c8bf661a0e93b9cd
tools: update V8 gypfiles for 11.1
commit sha eecb8841696e83e61722b306d9b74ab94f201de1
test: adapt debugger tests to V8 11.4 Accept a new `step` break message.
push time in 13 hours
pull request commentnodejs/node
stream: add setter & getter for default highWaterMark
CI: https://ci.nodejs.org/job/node-test-pull-request/50636/
comment created time in 13 hours
pull request commentnodejs/node
src: increase default semi space size to 64mb
Review requested:
- [ ] @nodejs/startup
comment created time in 13 hours
pull request commentnodejs/node
quic: implement various utilities classes to be used by the quic impl
CI: https://ci.nodejs.org/job/node-test-pull-request/50635/
comment created time in 17 hours
pull request commentnodejs/node
quic: implement various utilities classes to be used by the quic impl
CI: https://ci.nodejs.org/job/node-test-pull-request/50634/
comment created time in 17 hours
pull request commentnodejs/node
CI: https://ci.nodejs.org/job/node-test-pull-request/50633/
comment created time in 18 hours