schummar/schummar-translate 122
TypeScript powered translation library for React and Node.js.
Elegant bindings for working with Git in your Node applications
The all-in-one web framework designed for speed. ⭐️ Star to support our work!
Node.js loader for compiling ESM & TypeScript modules to CommonJS
Core utility functions used by esbuild-kit projects
Set up a modern web app by running one command.
push eventschummar/cross-state
commit sha 672e1cc7ac46f96593c6f7ab60a80a22c801e1f1
feat: more form types
push time in 2 days
push eventschummar/cross-state
commit sha 6e1bb54b60555cb2fa361cb60c738bd5cc9dd2f2
feat: better form onSubmit
push time in 2 days
Pull request review commentwithastro/astro
cloudflare integration: added config for _routes.json generation
export default function createIntegration(args?: Options): AstroIntegration { // move cloudflare specific files to the root const cloudflareSpecialFiles = ['_headers', '_redirects', '_routes.json'];+ if (!isModeDirectory) {+ cloudflareSpecialFiles.push('_worker.js');+ }
That is so that the _worker.js file does not make it into the _routes.json
. It would be handled like a static asset otherwise. You are right, that trying to copy it to the root does not make sense. The error is ignored, but still it's not good practice. I've moved the block slightly, so that it does not affect the copying of files and added a comment.
comment created time in 7 days
push eventschummar/astro
commit sha b07d3ff13a1f6ac242d978de6cca4c791e097844
moved the _worker.js in cloudflareSpecialFiles statement
push time in 7 days
push eventschummar/cross-state
commit sha ad873b7ccbf41c35431ea1dfe7e1c2d384928fee
fix: slow ForEachPath
push time in 9 days
pull request commentwithastro/astro
cloudflare integration: added config for _routes.json generation
Just putting this here so I get notified when I should come back and look at updated documentation! 🙌
@sarah11918 are the docs ok now?
comment created time in 11 days
push eventschummar/runp
commit sha 3c5a510413888257210e60911ab00a3606cb5153
fix: adjusted test
push time in 11 days
push eventschummar/cross-state
commit sha 4714a3cfdb5cf7bccd3a39595850e5346cef15a7
fix(form): ForEach fixes
push time in 15 days
push eventschummar/cross-state
commit sha 611d8cdb98a3c06a2130a44000a4bd79f906fba0
fix(form): ForEach type fixes
push time in 15 days
push eventschummar/cross-state
commit sha 587349d7416b715926fd0cadf8ac49272663c39c
feat(form): ForEach component
push time in 15 days
pull request commentwithastro/astro
cloudflare integration: added config for _routes.json generation
Could you clarify this point? I'm uncertain why the
functions
folder is deemed irrelevant. ThefunctionPerRoute
will generate multiple files within thefunctions
folder, as opposed to a singular[[path]].js
. It's essential that these files are processed automatically to ensure accurate output for both modes (include/exclude) in the_routes.json
.
What I mean is, the content of the functions
folder is not take into account when generating the _routes.json
file. As far as I know, functionPerRoute
also does not change the content of the routes
and pages
variables. However, since I don't understand all implications, maybe it's better to just test it as well. Better safe than sorry. => I have adjusted it now.
When a future PR indroduces analzying custom functions in the functions
folder, testing with different functionPerRoute
settings will become essential anyway.
comment created time in 16 days
push eventschummar/astro
commit sha 8ee05ad6adebd102019e265fb1a24e0c1f2380a2
worked on tests
push time in 16 days
push eventschummar/runp
commit sha 044c624db64d7514cf3a7beae06484b544afdc8a
feat: linear output by default BREAKING CHANGE: linear output by default
push time in 16 days
push eventschummar/schummar-table
commit sha 1d96748c170b2d362b8ff48bd3f9a4079ec260da
fix: immer version
push time in 16 days
push eventschummar/astro
commit sha 98d501bde6afe51fe2d3dabd0b6f761d9e590398
[ci] release (#8442) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
commit sha 50c0a803e37f89d83856c5b294abf1f0f9a16bd3
refactor: move type utils into a single file (#8462)
commit sha 7eea37a075c6abb1de715de76d1911ff41e8ab13
Fix multi-layout head injection (#8449) * Fix multi-layout head injection * Tracing fix * Improved walk * Upgrade the compiler version --------- Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
commit sha b65e84d888cf0821c6125190927fdbf4945b1769
[ci] format
commit sha 0a2567c288bc2a3ccc92afd643944c9a4e6d604b
[ci] release (#8465) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
commit sha 435b10549878281ad2bb60207cb86f312a4a809f
Fix: lang unspecified code blocks (#8461)
commit sha a6a516d9446a50cc32fbd7201b243c63b3a4db43
fix(types): make `image.service` optional (#8492)
commit sha 78b82bb3929bee5d8d9bd32d65374956ddb05859
fix(astro): support `content/config.mts` (#8484) Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
commit sha 0ca332ba4ab82cc04872776398952867b0f43d33
Bugfixes for back navigation in the view transition client-side router (#8491) * Bugfixes for back navigation in the view transition client-side router * re-introduced pushState on self links as required for update of browser's address bar * format
commit sha 1ed21d10db3f57e19861a865722d039238e82c8b
Clear caches older than 5 days (#8494)
commit sha fa77fa63d944f709a37f08be93f0d14fe1d91188
Prevent style removal of client:only components (#8472)
commit sha c934b087d738401f2394c3738d156993e66b4b64
[ci] format
commit sha 5e1099f686abcc7026bd4fa74727f3b311c6d6d6
fix: minify HTML for redirects when emitted as HTML files (#8504)
commit sha 23f9536de0456ed2ddc9a77f7aef773ab6a8e73c
chore: correct description of `attribute` option in `scopedStyleStrategy` (#8506) * chore: correct description of `attribute` option in `scopedStyleStrategy` * chore: fix typo (specifity -> specificity)
commit sha 345cb4aeb99c08288baf2d6e17ce64c5e5ecac80
Support AVIF input assets (#8380) Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com> Co-authored-by: Princesseuh <princssdev@gmail.com>
commit sha b384cf4f7d3d257a560c1c8ffbf35d3b96a21d46
[ci] format
commit sha 2c9614469674509b3e3bc21a4471a1aeb9b4141f
feat(@astrojs/cloudflare): add runtime support to `astro dev` (#8426) * add necessary libs * cleanup stale code * add base feature-set of runtime to `astro dev` * fix lockfile * remove future code Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com> * remove future code Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com> * remove future code Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com> * remove future code Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com> * remove future code Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com> * address review comments * fix linting issue * add docs & tests * fix test paths * add changeset * update README.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * fix docs & make adapter options optional * fix package resolve mode * fix pnpm-lock --------- Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
commit sha fdf9b66f9bec03e9c93f0ead9befd4a2da2d946a
[ci] format
commit sha f41157e955b44bd12e9c59eebfe0cd5ef10d435a
chore: do a minor for avif support (#8508)
commit sha cda7d80ac5c2b7fdc2763a89a1d3663df256c0cf
chore: revert avif change (#8509)
push time in 16 days
push eventschummar/astro
commit sha 0002115474e633f330dcb6892124a16dec6b558e
worked on tests
push time in 16 days
pull request commentwithastro/astro
cloudflare integration: added config for _routes.json generation
I have a few suggestions to enhance this:
- To maintain consistency, could we rename the test file as follows?
renamed: packages/integrations/cloudflare/test/routes-json.js -> packages/integrations/cloudflare/test/routes-json.test.js
Sorry for missing the ".test" part. Maybe third time's the charm 😁. I did the same adjustment for the test's fixtures, renaming the path from routesJson
to routes-json
.
- I'd love to see a variety of test cases (non-blocking for me), such as:
- Tests for mode: 'advanced'
Done. Executing all test cases for both modes now.
- Tests for both include & exclude strategy using a custom function (they should target the same files but with different syntax)
Is this not already covered by the "with additional include
entries"/"with additional exclude
entries" test cases? Files do not really play a role here. The content of the functions
folder is not considered at all, the user supplied values are simply added to the include
/exclude
arrays.
- Tests for functionPerRoute: true
Do you expect that option has any impact on the resulting _routes.json
file? It should only influence the content of the functions
folder and that does not play a role here.
- A test incorporating assets
I've added an asset file as well as a _redirects
file to the fixtures' public
folder.
- Lastly, I'm concerned that the include strategy might not address all edge cases. (During my manual testing, I encountered some issues. I'd be happy to discuss this on a Discord thread in case I missed something.) If that's the case, I'd suggest not setting the default to auto. Perhaps making exclude the default would be more appropriate.
UPDATE: Please ignore point 3 for now. I believe I've discovered an existing bug that I need to address. I'm still in the process of evaluating it.
That is still an interesting question: Defaulting to the exclude
strategy might be safer. However when having mostly static pages and only a few dynamic ones the include
/auto
strategies usually produce a lot better _routes.json
files. As far as I know this is the most common use case for Astro, right? People will run into the 100 entries limit very frequently.
comment created time in 16 days
Pull request review commentwithastro/astro
cloudflare integration: added config for _routes.json generation
export default defineConfig({ Note that this adapter does not support using [Cloudflare Pages Middleware](https://developers.cloudflare.com/pages/platform/functions/middleware/). Astro will bundle the [Astro middleware](https://docs.astro.build/en/guides/middleware/) into each page. +### routes.strategy++`routes.strategy: "auto" | "include" | "exclude"`++default `"auto"`++If no [custom `_routes.json`](#custom-_routesjson) is provided, `@astrojs/cloudflare` will generate one for you. There are two ways to generate the `_routes.json`:++1. For each page or endpoint in your application that is not prerendered, an entry in the `include` array will be generated. For each page that is prerendered and whoose path is matched by an `include` entry, an entry in the `exclude` array will be generated.++2. One `"/*"` entry in the `include` array will be generated. For each page that is prerendered, an entry in the `exclude` array will be generated.++Setting `routes.strategy` to `"include"` will generate a `_routes.json` with the first strategy. Setting it to `"exclude"` will use the second strategy. Setting it to `"auto"` will use the strategy that generates the least amount of entries.
Yes, understood. It's kind of hard to separate implementation from result here because caring about the contents of the _routes.json
file is already rather low level. I've made another attempt with less details but more examples. Enough or should I slim it down even more?
comment created time in 16 days
push eventschummar/astro
commit sha 00ba7fceb063f832794fe81306ba223a1a466918
worked on docs
push time in 16 days
Pull request review commentwithastro/astro
cloudflare integration: added config for _routes.json generation
export default defineConfig({ Note that this adapter does not support using [Cloudflare Pages Middleware](https://developers.cloudflare.com/pages/platform/functions/middleware/). Astro will bundle the [Astro middleware](https://docs.astro.build/en/guides/middleware/) into each page. +### routes.strategy++`routes.strategy: "auto" | "include" | "exclude"`++default `"auto"`++If no [custom `_routes.json`](#custom-_routesjson) is provided, `@astrojs/cloudflare` will generate one for you. There are two ways to generate the `_routes.json`:++1. For each page or endpoint in your application that is not prerendered, an entry in the `include` array will be generated. For each page that is prerendered and whoose path is matched by an `include` entry, an entry in the `exclude` array will be generated.++2. One `"/*"` entry in the `include` array will be generated. For each page that is prerendered, an entry in the `exclude` array will be generated.++Setting `routes.strategy` to `"include"` will generate a `_routes.json` with the first strategy. Setting it to `"exclude"` will use the second strategy. Setting it to `"auto"` will use the strategy that generates the least amount of entries.++### routes.include++`routes.include: string[]`++default `[]`++If you want to use the automatic `_routes.json` generation, but want to include additional routes (e.g. when having custom functions in the `functions` folder), you can use the `routes.include` option to add additional routes to the `include` array.++### routes.exclude++`routes.exclude: string[]`++default `[]`++If you want to use the automatic `_routes.json` generation, but want to exclude additional routes, you can use the `routes.exclude` option to add additional routes to the `exclude` array.+
To some degree, yes. They can have dynamic parts, like Astro pages too. So it's not strictly possible to know all correct routes from just looking at the files. One could however define, that static assets always beat dynamic path parts - again like Astro pages - and let users override include
and exclude
to implement anything more specific.
comment created time in 17 days
pull request commentwithastro/astro
cloudflare integration: added config for _routes.json generation
I have made some update but did not address all feedback yet. Will continue later, I'll notify you, when I'm done.
comment created time in 17 days
Pull request review commentwithastro/astro
cloudflare integration: added config for _routes.json generation
export default defineConfig({ Note that this adapter does not support using [Cloudflare Pages Middleware](https://developers.cloudflare.com/pages/platform/functions/middleware/). Astro will bundle the [Astro middleware](https://docs.astro.build/en/guides/middleware/) into each page. +### routes.strategy++`routes.strategy: "auto" | "include" | "exclude"`++default `"auto"`++If no [custom `_routes.json`](#custom-_routesjson) is provided, `@astrojs/cloudflare` will generate one for you. There are two ways to generate the `_routes.json`:++1. For each page or endpoint in your application that is not prerendered, an entry in the `include` array will be generated. For each page that is prerendered and whoose path is matched by an `include` entry, an entry in the `exclude` array will be generated.++2. One `"/*"` entry in the `include` array will be generated. For each page that is prerendered, an entry in the `exclude` array will be generated.++Setting `routes.strategy` to `"include"` will generate a `_routes.json` with the first strategy. Setting it to `"exclude"` will use the second strategy. Setting it to `"auto"` will use the strategy that generates the least amount of entries.++### routes.include++`routes.include: string[]`++default `[]`++If you want to use the automatic `_routes.json` generation, but want to include additional routes (e.g. when having custom functions in the `functions` folder), you can use the `routes.include` option to add additional routes to the `include` array.++### routes.exclude++`routes.exclude: string[]`++default `[]`++If you want to use the automatic `_routes.json` generation, but want to exclude additional routes, you can use the `routes.exclude` option to add additional routes to the `exclude` array.+
I have updated the example. There is indeed no need to reference the functions folder, but rather custom functions withing the functions folder that were not generated by Astro. I hope the updated example clarifies this.
comment created time in 17 days
push eventschummar/astro
commit sha e910655f5651ba5ee6b41bffdf3335e1b129a836
worked on docs
push time in 17 days
push eventschummar/astro
commit sha a341a70b3cf8e443f582fe88b5648efdd3e8a645
worked on tests
push time in 17 days