profile
viewpoint

swift-server/swift-aws-lambda-runtime 1049

Swift implementation of AWS Lambda Runtime

swift-server/async-http-client 734

HTTP client library built on SwiftNIO

swift-server/http 709

:warning: Historical HTTP API - please use https://github.com/swift-server/async-http-client instead

swift-server/vscode-swift 487

Visual Studio Code Extension for Swift

swift-server/work-group 355

:warning: Historical workgroup organisation

swift-server/swift-service-lifecycle 298

Cleanly startup and shutdown server application, freeing resources in order before exiting.

swift-server/swift-backtrace 281

💥 Backtraces for Swift on Linux and Windows

swift-server/guides 264

Guides for building, debugging and deploying Swift Server applications

swift-server/sswg 145

Swift Server Working Group (SSWG)

swift-server/swiftly 87

A Swift toolchain installer and manager, written in Swift.

startedswift-server/swift-openapi-async-http-client

started time in 3 hours

PR opened swift-server/swift-memcache-gsoc

Implement a get request

Updated our Encoder and Decoder to serialize/deserialize a MemcachedResponse. This pr closes #6.

Motivation:

This marks the beginning for being able to handle get operations.

Modifications:

...

Result:

...

+146 -7

0 comment

8 changed files

pr created time in 5 hours

PR merged swift-server/swift-service-lifecycle

Reviewers
update code of conduct

motivation: align CoC across the swift project

changes: change CoC to link to the swift.org version

+1 -53

0 comment

1 changed file

tomerd

pr closed time in 14 hours

push eventswift-server/swift-service-lifecycle

tomer doron

commit sha cf346f7536ee699f755fc90dffc4393894daa16e

update code of conduct (#143) motivation: align CoC across the swift project changes: change CoC to link to the swift.org version

view details

push time in 14 hours

PullRequestReviewEvent

Pull request review commentswift-server/swift-kafka-gsoc

KafkaProducerConfig: add `allow.auto.create.topics` option

 public struct KafkaProducerConfig: Hashable, Equatable {         set { self.dictionary["message.send.max.retries"] = String(newValue) }     } +    /// Allow automatic topic creation on the broker when subscribing to or assigning non-existent topics. The broker must also be configured with auto.create.topics.enable=true for this configuration to take effect. Note: the default value (true) for the producer is different from the default value (false) for the consumer. Further, the consumer default value is different from the Java consumer (true), and this property is not supported by the Java producer. Requires broker version >= 0.11.0.0, for older broker versions only the broker configuration applies.

I do not see the issue with default values:

In KafkaProducerConfig it should be true, in KafkaConsumerConfig it should be false by default

felixschlegel

comment created time in 14 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentswift-server/swift-kafka-gsoc

KafkaProducerConfig: add `allow.auto.create.topics` option

 public struct KafkaProducerConfig: Hashable, Equatable {         set { self.dictionary["message.send.max.retries"] = String(newValue) }     } +    /// Allow automatic topic creation on the broker when subscribing to or assigning non-existent topics. The broker must also be configured with auto.create.topics.enable=true for this configuration to take effect. Note: the default value (true) for the producer is different from the default value (false) for the consumer. Further, the consumer default value is different from the Java consumer (true), and this property is not supported by the Java producer. Requires broker version >= 0.11.0.0, for older broker versions only the broker configuration applies.

Broke the documentation comment down into multiple lines ✅

felixschlegel

comment created time in 15 hours

PR opened swift-server/swift-service-lifecycle

update code of conduct

motivation: align CoC across the swift project

changes: change CoC to link to the swift.org version

+1 -53

0 comment

1 changed file

pr created time in 15 hours

PR merged swift-server/swift-aws-lambda-runtime

update code of conduct

motivation: align CoC across the swift project

changes: change CoC to link to the swift.org version

+1 -36

1 comment

1 changed file

tomerd

pr closed time in 15 hours

push eventswift-server/swift-aws-lambda-runtime

tomer doron

commit sha e7751d0afbfdd3887572be438256d85205d0086b

update code of conduct (#303) motivation: align CoC across the swift project changes: change CoC to link to the swift.org version

view details

push time in 15 hours

push eventswift-server/swift-aws-lambda-events

tomer doron

commit sha 1afa339fc5b27a038d10ca773537f3be115786c9

update code of conduct (#36) motivation: align CoC across the swift project changes: change CoC to link to the swift.org version

view details

push time in 15 hours

PR merged swift-server/swift-aws-lambda-events

update code of conduct

motivation: align CoC across the swift project

changes: change CoC to link to the swift.org version

+1 -36

1 comment

1 changed file

tomerd

pr closed time in 15 hours

pull request commentswift-server/swift-aws-lambda-events

update code of conduct

@swift-server-bot test this please

tomerd

comment created time in 15 hours

pull request commentswift-server/swift-aws-lambda-runtime

update code of conduct

@swift-server-bot test this please

tomerd

comment created time in 15 hours

PullRequestReviewEvent
PullRequestReviewEvent

PR opened swift-server/swift-aws-lambda-events

update code of conduct

motivation: align CoC across the swift project

changes: change CoC to link to the swift.org version

+1 -36

0 comment

1 changed file

pr created time in 16 hours

PR opened swift-server/swift-aws-lambda-runtime

update code of conduct

motivation: align CoC across the swift project

changes: change CoC to link to the swift.org version

+1 -36

0 comment

1 changed file

pr created time in 16 hours

push eventswift-server/async-http-client

Cory Benfield

commit sha 960af0dcf4aaf143c9f2383ebb014d655e6920a3

Adopt the Swift CoC (#691) Motivation: We're centralizing on the Swift code of conduct, so we'll x-reference that instead of holding our own. Modifications: Hyperlink out to Swift. Result: Shared CoC across the projects.

view details

push time in 16 hours

PR merged swift-server/async-http-client

Adopt the Swift CoC needs-no-version-bump

Motivation:

We're centralizing on the Swift code of conduct, so we'll x-reference that instead of holding our own.

Modifications:

Hyperlink out to Swift.

Result:

Shared CoC across the projects.

+2 -52

0 comment

1 changed file

Lukasa

pr closed time in 16 hours

PullRequestReviewEvent

PR opened swift-server/async-http-client

Adopt the Swift CoC needs-no-version-bump

Motivation:

We're centralizing on the Swift code of conduct, so we'll x-reference that instead of holding our own.

Modifications:

Hyperlink out to Swift.

Result:

Shared CoC across the projects.

+2 -52

0 comment

1 changed file

pr created time in 16 hours

Pull request review commentswift-server/swift-kafka-gsoc

KafkaProducerConfig: add `allow.auto.create.topics` option

 public struct KafkaProducerConfig: Hashable, Equatable {         set { self.dictionary["message.send.max.retries"] = String(newValue) }     } +    /// Allow automatic topic creation on the broker when subscribing to or assigning non-existent topics. The broker must also be configured with auto.create.topics.enable=true for this configuration to take effect. Note: the default value (true) for the producer is different from the default value (false) for the consumer. Further, the consumer default value is different from the Java consumer (true), and this property is not supported by the Java producer. Requires broker version >= 0.11.0.0, for older broker versions only the broker configuration applies.

Can we break this into multiple lines?

felixschlegel

comment created time in 17 hours

PullRequestReviewEvent

Pull request review commentswift-server/swift-kafka-gsoc

KafkaProducerConfig: add `allow.auto.create.topics` option

 public struct KafkaProducerConfig: Hashable, Equatable {         set { self.dictionary["message.send.max.retries"] = String(newValue) }     } +    /// Allow automatic topic creation on the broker when subscribing to or assigning non-existent topics. The broker must also be configured with auto.create.topics.enable=true for this configuration to take effect. Note: the default value (true) for the producer is different from the default value (false) for the consumer. Further, the consumer default value is different from the Java consumer (true), and this property is not supported by the Java producer. Requires broker version >= 0.11.0.0, for older broker versions only the broker configuration applies.

Also the doc stats the default values for consumer and producer are different but our code is not upholding this.

felixschlegel

comment created time in 16 hours

PullRequestReviewEvent

Pull request review commentswift-server/swift-kafka-gsoc

`KafkaConsumerConfig` add `SwiftKafka` options

 public struct KafkaConsumerConfig: Hashable, Equatable {      // MARK: - Helpers -    func getDebugOptions() -> [KafkaSharedConfiguration.DebugOption] {+    func getDebugOptions() -> [ConfigEnums.DebugOption] {         guard let options = dictionary["debug"] else {             return []         }         return options.components(separatedBy: ",")-            .map { KafkaSharedConfiguration.DebugOption(description: $0) }+            .map { ConfigEnums.DebugOption(description: $0) }     } -    func getIPAddressFamily() -> KafkaSharedConfiguration.IPAddressFamily? {+    func getIPAddressFamily() -> ConfigEnums.IPAddressFamily? {         guard let value = dictionary["broker.address.family"] else {             return nil         }-        return KafkaSharedConfiguration.IPAddressFamily(description: value)+        return ConfigEnums.IPAddressFamily(description: value)     } -    func getSecurityProtocol() -> KafkaSharedConfiguration.SecurityProtocol? {+    func getSecurityProtocol() -> ConfigEnums.SecurityProtocol? {         guard let value = dictionary["security.protocol"] else {             return nil         }-        return KafkaSharedConfiguration.SecurityProtocol(description: value)+        return ConfigEnums.SecurityProtocol(description: value)     } -    func getSASLMechanism() -> KafkaSharedConfiguration.SASLMechanism? {+    func getSASLMechanism() -> ConfigEnums.SASLMechanism? {         guard let value = dictionary["sasl.mechanism"] else {             return nil         }-        return KafkaSharedConfiguration.SASLMechanism(description: value)+        return ConfigEnums.SASLMechanism(description: value)     } -    func getAutoOffsetReset() -> KafkaSharedConfiguration.AutoOffsetReset? {+    func getAutoOffsetReset() -> ConfigEnums.AutoOffsetReset? {         guard let value = dictionary["auto.offset.reset"] else {             return nil         }-        return KafkaSharedConfiguration.AutoOffsetReset(description: value)+        return ConfigEnums.AutoOffsetReset(description: value)     } }  // MARK: - ConfigEnums + AutoOffsetReset -extension KafkaSharedConfiguration {+extension ConfigEnums {+    /// A struct representing different back pressure strategies for receiving message acknowledgements in ``KafkaConsumer``.

Is this correct?

felixschlegel

comment created time in 17 hours

Pull request review commentswift-server/swift-kafka-gsoc

`KafkaConsumerConfig` add `SwiftKafka` options

 // //===----------------------------------------------------------------------===// +import Crdkafka+import struct Foundation.UUID+ public struct KafkaConsumerConfig: Hashable, Equatable {+    // MARK: - SwiftKafka-specific Config properties++    /// The backpressure strategy to be used for receiveing message acknowledgements.+    public var backPressureStrategy: ConfigEnums.BackPressureStrategy = .highLowWatermark(+        lowWatermark: 10,+        highWatermark: 50+    )++    // Implicitly unwrapped, because this just backs+    // the non-optional consumptionStrategy variable+    private var _consumptionStrategy: ConfigEnums.ConsumptionStrategy!

We shouldn't use an IOU here but rather require this passed through the init

felixschlegel

comment created time in 17 hours

more