profile
viewpoint

tudorbarbu/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

tudorbarbu/fractastic 0

Fractastic is a simple and approachable fractal generator written in C.

tudorbarbu/mac_address 0

Cross-platform retrieval of a network interface MAC address.

tudorbarbu/nativejson-benchmark 0

C/C++ JSON parser/generator benchmark

tudorbarbu/node-cron 0

Cron for NodeJS.

pull request commentkelektiv/node-cron

Eslint update to latest + lint fixes

thanks! would you mind explaining the changes to .eslintrc?

By using "extends": [ "standard", "plugin:jest/recommended", "plugin:import/recommended", "plugin:n/recommended", "plugin:prettier/recommended", "plugin:promise/recommended" ], it will enable all the recommended linter options defined by those plugins Additional rules can be enabled by appending the rules section if desired. The plugins list is no longer needed since it's handled by the extend part. As it can be seen from the lint fixes, more rules are now enabled (thanks to the recommended configs) Furthermore, rules will need less manual updates since configs will be updated when something important appear and the dependency is updated

tudorbarbu

comment created time in 2 months

pull request commentkelektiv/node-cron

Eslint update to latest + lint fixes

I've made the changes for only publishing the lib The linter also passes now

tudorbarbu

comment created time in 3 months

push eventtudorbarbu/node-cron

Tudor Barbu

commit sha 7faaebd01f11564f5f05b695463aeb071c26bcab

Publish only the necessary files

view details

push time in 3 months

pull request commentkelektiv/node-cron

Eslint update to latest + lint fixes

While fixing the build for node 14, by adding the checks from the new n(ode) plugin which was required by one of the new packages, I've found out that the test files are also published

~/git/node-cron/tests/cron.test.js
  2:23  error  "sinon" is not published  n/no-unpublished-require

~/git/node-cron/tests/crontime.test.js
  2:23  error  "sinon" is not published  n/no-unpublished-require

This lint error states that sinon is required in the test files, and as the test files are published, it should be a dependency of the package when publishing. What do you think would be the best course of action?

  1. Unpublish the tests
  2. Ignore this rule for the test files
tudorbarbu

comment created time in 3 months

push eventtudorbarbu/node-cron

intcreator

commit sha 693de61e8ca1b433b55a1fb245df22f396a4ab7e

Update testing libraries for Node v19 and add passing range test

view details

intcreator

commit sha 5f316a8c07d9b4e8e9a471f6792058b23a043e59

fix lint

view details

Tudor Barbu

commit sha ad45d4578ed5c3da4afef761332f6657615b402a

Update eslint package, plugins and config

view details

Tudor Barbu

commit sha 917f807d916fec98facc8b29d75c8da43760edbd

Fix jest lint issues

view details

Tudor Barbu

commit sha 601a599cb406c2219200e8d70497ab22110f4270

Fix lint issue

view details

Tudor Barbu

commit sha d12f00698fa1b99c0331c3aee2526231a7644890

Change var to let or const to fix lints

view details

Tudor Barbu

commit sha 1dfd44fe29f9f63a2dd8697df196db7ca9a70066

Replace deprecated eslint node package and add node 14 dependency

view details

push time in 3 months

push eventtudorbarbu/node-cron

intcreator

commit sha 693de61e8ca1b433b55a1fb245df22f396a4ab7e

Update testing libraries for Node v19 and add passing range test

view details

intcreator

commit sha 5f316a8c07d9b4e8e9a471f6792058b23a043e59

fix lint

view details

push time in 3 months

PR opened kelektiv/node-cron

Eslint update to latest + lint fixes
+3015 -2364

0 comment

8 changed files

pr created time in 3 months

create barnchtudorbarbu/node-cron

branch : linter-update

created branch time in 3 months

fork tudorbarbu/node-cron

Cron for NodeJS.

fork in 3 months

more